Skip to content

Commit

Permalink
ADOrganizationalUnit : Removing Credential from the list of desired v…
Browse files Browse the repository at this point in the history
…alues to compare (#623)
  • Loading branch information
jmos5156 authored Sep 27, 2020
1 parent e346f4b commit dcd1160
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
6 changes: 4 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ For older change log history see the [historic changelog](HISTORIC_CHANGELOG.md)

## [Unreleased]

### Added
### Added

- ADFineGrainedPasswordPolicy
  - New resource for creating and updating Fine Grained Password Policies for AD principal subjects.
Expand All @@ -23,7 +23,6 @@ For older change log history see the [historic changelog](HISTORIC_CHANGELOG.md)
- Removed redundant common functions `Resolve-DomainFQDN` and `Set-DscADComputer`.
- Added ActiveDirectoryDsc.Common Module markdown help.
- Updated the `DscResource.Common` module to `v0.9.0`.

- ADDomainTrust
- Move `Get-ActiveDirectoryDomain` and `Get-ActiveDirectoryForest` functions
into the `ActiveDirectoryDsc.Common` module.
Expand All @@ -45,6 +44,9 @@ For older change log history see the [historic changelog](HISTORIC_CHANGELOG.md)
by adding and using the 'Members' property from `Get-ADGroup` and sending the resulting DistinguishedName to
`Get-ADObject` when `Get-ADGroupMember` throws a specific error.
([issue #616](https://github.com/dsccommunity/ActiveDirectoryDsc/issues/616)).
- ADOrganizationalUnit
- Removed Credential from the list of desired values to compare when passed
([issue #624](https://github.com/dsccommunity/ActiveDirectoryDsc/issues/624)).
- ADReplicationSiteLink
- Fixed setting options after the resource is initially created
([issue #605](https://github.com/dsccommunity/ActiveDirectoryDsc/issues/605)).
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ function Test-TargetResource
{
# Resource should exist
$propertiesNotInDesiredState = (
Compare-ResourcePropertyState -CurrentValue $targetResource -DesiredValues $PSBoundParameters |
Compare-ResourcePropertyState -CurrentValue $targetResource -DesiredValues $PSBoundParameters -IgnoreProperties 'Credential' |
Where-Object -Property InDesiredState -eq $false)

if ($propertiesNotInDesiredState)
Expand Down

0 comments on commit dcd1160

Please sign in to comment.