Fixes #82

[PlagueHO]

Pull Request (PR) description

• Combined all ActiveDirectoryCSDsc.ResourceHelper module functions into
  ActiveDirectoryCSDsc.Common module and renamed to ActiveDirectoryCSDsc.CommonHelper
  module.
• Opted into Common Tests 'Common Tests - Validate Localization' -
  fixes Issue #82.

This Pull Request (PR) fixes the following issues

• Fixes Opt-In to Common Tests - Validating Localization #82

Task list

• Added an entry under the Unreleased section of the change log in the CHANGELOG.md.
  Entry should say what was changed, and how that affects users (if applicable).
• Resource documentation added/updated in README.md in the resource folder.
• Resource parameter descriptions added/updated in schema.mof
  and comment-based help.
• Comment-based help added/updated.
• Localization strings added/updated in all localization files as appropriate.
• Examples appropriately added/updated.
• Unit tests added/updated. See DSC Resource Testing Guidelines.
• Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
• New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

@johlju - would you mind reviewing when you have time?

---

This change is 

[codecov-io]

Codecov Report

Merging #83 into dev will increase coverage by 4%.
The diff coverage is 100%.

@@        Coverage Diff        @@
##           dev   #83   +/-   ##
=================================
+ Coverage   93%   98%   +4%     
=================================
  Files        7     6    -1     
  Lines      443   517   +74     
=================================
+ Hits       416   508   +92     
+ Misses      27     9   -18

[johlju]

Reviewed 18 of 18 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @PlagueHO)

---

Modules/ActiveDirectoryCSDsc.Common/ActiveDirectoryCSDsc.Common.psm1, line 483 at r1 (raw file):

$script:localizedData = Get-LocalizedData -ResourceName 'ActiveDirectoryCSDsc.Common' -ScriptRoot $PSScriptRoot

Maybe have this at the end just before the Export-ModuleMember so it is less hidden :)

[PlagueHO]

All done! Thanks @johlju

Reviewable status: 17 of 18 files reviewed, 1 unresolved discussion (waiting on @johlju)

---

Modules/ActiveDirectoryCSDsc.Common/ActiveDirectoryCSDsc.Common.psm1, line 483 at r1 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

$script:localizedData = Get-LocalizedData -ResourceName 'ActiveDirectoryCSDsc.Common' -ScriptRoot $PSScriptRoot

Maybe have this at the end just before the Export-ModuleMember so it is less hidden :)

Done.

[johlju]

Reviewed 1 of 1 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved