Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AdcsAuthorityInformationAccess: always makes a change #128, #138 #139

Closed
wants to merge 8 commits into from

Conversation

dan-hughes
Copy link
Contributor

@dan-hughes dan-hughes commented Apr 2, 2024

Pull Request (PR) description

Removed the AllowRestartService parameter from being tested/compared.
Updated Get-CaAiaUriList to force a System.String[] to be returned regardless of single or multiple values.

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry under the Unreleased section of the change log in the CHANGELOG.md.
    Entry should say what was changed, and how that affects users (if applicable).
  • Resource documentation added/updated in README.md in resource folder.
  • Resource parameter descriptions added/updated in schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is Reviewable

Copy link

codecov bot commented Apr 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97%. Comparing base (fc7d5d1) to head (68b19fc).
Report is 1 commits behind head on main.

❗ Current head 68b19fc differs from pull request most recent head 965ad60. Consider uploading reports for the commit 965ad60 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@         Coverage Diff         @@
##           main   #139   +/-   ##
===================================
  Coverage    97%    97%           
===================================
  Files         8      8           
  Lines       521    523    +2     
===================================
+ Hits        506    508    +2     
  Misses       15     15           

@dan-hughes dan-hughes changed the title Fix AdcsAuthorityInformationAccess: always makes a change #138 Fix AdcsAuthorityInformationAccess: always makes a change #128, #138 Apr 18, 2024
@dan-hughes dan-hughes closed this Apr 18, 2024
@dan-hughes dan-hughes deleted the fix-issue-138 branch April 18, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant