Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Gitversion to latest pattern - Fixes #126 #127

Merged
merged 1 commit into from
Jan 20, 2021
Merged

Update Gitversion to latest pattern - Fixes #126 #127

merged 1 commit into from
Jan 20, 2021

Conversation

PlagueHO
Copy link
Member

@PlagueHO PlagueHO commented Jan 20, 2021 •
edited by johlju
Loading

Pull Request (PR) description

This PR updates GitVersion.yml to the latest pattern.

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry under the Unreleased section of the change log in the CHANGELOG.md.
    Entry should say what was changed, and how that affects users (if applicable).
  • Resource documentation added/updated in README.md in resource folder.
  • Resource parameter descriptions added/updated in schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

@johlju - would you mind reviewing when you have time?

This change is Reviewable

@PlagueHO PlagueHO added the needs review The pull request needs a code review. label Jan 20, 2021
johlju
johlju approved these changes Jan 20, 2021
View reviewed changes
Copy link
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@johlju johlju added ready for merge The pull request was approved by the community and is ready to be merged by a maintainer. and removed needs review The pull request needs a code review. labels Jan 20, 2021
@PlagueHO PlagueHO merged commit dc0e72d into dsccommunity:main Jan 20, 2021
@PlagueHO PlagueHO deleted the Issue-126 branch January 20, 2021 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johlju johlju johlju approved these changes

Assignees
No one assigned
Labels
ready for merge The pull request was approved by the community and is ready to be merged by a maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update GitVersion.yml to use latest pattern
2 participants
@PlagueHO @johlju