Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to DSCResource.Common - Fixes #117 #120

Merged
merged 2 commits into from
Jun 20, 2020

Conversation

PlagueHO
Copy link
Member

@PlagueHO PlagueHO commented Jun 20, 2020

Pull Request (PR) description

  • Fixed build failures caused by changes in ModuleBuilder module v1.7.0
    by changing CopyDirectories to CopyPaths - Fixes Issue #119.
  • Updated to use the common module DscResource.Common - Fixes Issue #117.
  • Pin Pester module to 4.10.1 because Pester 5.0 is missing code
    coverage - Fixes Issue #118.

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry under the Unreleased section of the change log in the CHANGELOG.md.
    Entry should say what was changed, and how that affects users (if applicable).
  • Resource documentation added/updated in README.md in resource folder.
  • Resource parameter descriptions added/updated in schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

@johlju - would you mind reviewing this when you have time?


This change is Reviewable

@PlagueHO PlagueHO added the needs review The pull request needs a code review. label Jun 20, 2020
Copy link
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 13 of 13 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@PlagueHO PlagueHO changed the title Issue 117 Convert to DSCResource.Common - Fixes #117 Jun 20, 2020
@PlagueHO PlagueHO merged commit 5e2daad into dsccommunity:master Jun 20, 2020
@PlagueHO PlagueHO deleted the Issue-117 branch June 20, 2020 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs review The pull request needs a code review.
Projects
None yet
2 participants