Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING CHANGE: Update to new CI Process - Fixes #105 #106

Merged
merged 6 commits into from
Feb 29, 2020

Conversation

PlagueHO
Copy link
Member

@PlagueHO PlagueHO commented Feb 15, 2020

Pull Request (PR) description

This PR updates the module to the new CI process and renames MSFT to DSC.

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry under the Unreleased section of the change log in the CHANGELOG.md.
    Entry should say what was changed, and how that affects users (if applicable).
  • Resource documentation added/updated in README.md in the resource folder.
  • Resource parameter descriptions added/updated in schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

@johlju - would you mind reviewing for me?


This change is Reviewable

@PlagueHO PlagueHO added the needs review The pull request needs a code review. label Feb 17, 2020
@PlagueHO PlagueHO requested a review from johlju February 21, 2020 04:50
@johlju
Copy link
Member

johlju commented Feb 22, 2020

I will review this as soon as I have a chance. Hopefully later today. 🙂 I trade you one PR in FileSystemDsc. 😉

Copy link
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

No blocking comments.

Reviewed 82 of 82 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved


source/en-US/about_ActiveDirectoryCSDsc.help.txt, line 9 at r1 (raw file):

installing or uninstalling

Not configuring? 🤔


tests/Unit/DSC_AdcsTemplate.Tests.ps1, line 285 at r1 (raw file):

Remove-Module -Name AdcsStub -Force

SHouldn't this be in the function Invoke-TestCleanup? If so, throughout.

@johlju johlju added ready for merge The pull request was approved by the community and is ready to be merged by a maintainer. and removed needs review The pull request needs a code review. labels Feb 22, 2020
Copy link
Member Author

@PlagueHO PlagueHO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 73 of 82 files reviewed, all discussions resolved (waiting on @johlju)


source/en-US/about_ActiveDirectoryCSDsc.help.txt, line 9 at r1 (raw file):

Previously, johlju (Johan Ljunggren) wrote…
installing or uninstalling

Not configuring? 🤔

Good point. Corrected.


tests/Unit/DSC_AdcsTemplate.Tests.ps1, line 285 at r1 (raw file):

Previously, johlju (Johan Ljunggren) wrote…
Remove-Module -Name AdcsStub -Force

SHouldn't this be in the function Invoke-TestCleanup? If so, throughout.

Fixed.

Copy link
Member Author

@PlagueHO PlagueHO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you sign off again @johlju ? Thank you! 😁

Reviewable status: 73 of 82 files reviewed, all discussions resolved (waiting on @johlju)

Copy link
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 9 of 9 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@PlagueHO PlagueHO merged commit 92005a7 into dsccommunity:dev Feb 29, 2020
@PlagueHO PlagueHO deleted the Issue-105 branch February 29, 2020 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for merge The pull request was approved by the community and is ready to be merged by a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update module to new CI and release process
2 participants