-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BREAKING CHANGE: Update to new CI Process - Fixes #105 #106
Conversation
I will review this as soon as I have a chance. Hopefully later today. 🙂 I trade you one PR in FileSystemDsc. 😉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No blocking comments.
Reviewed 82 of 82 files at r1.
Reviewable status: complete! all files reviewed, all discussions resolved
source/en-US/about_ActiveDirectoryCSDsc.help.txt, line 9 at r1 (raw file):
installing or uninstalling
Not configuring? 🤔
tests/Unit/DSC_AdcsTemplate.Tests.ps1, line 285 at r1 (raw file):
Remove-Module -Name AdcsStub -Force
SHouldn't this be in the function Invoke-TestCleanup? If so, throughout.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 73 of 82 files reviewed, all discussions resolved (waiting on @johlju)
source/en-US/about_ActiveDirectoryCSDsc.help.txt, line 9 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
installing or uninstalling
Not configuring? 🤔
Good point. Corrected.
tests/Unit/DSC_AdcsTemplate.Tests.ps1, line 285 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Remove-Module -Name AdcsStub -Force
SHouldn't this be in the function Invoke-TestCleanup? If so, throughout.
Fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you sign off again @johlju ? Thank you! 😁
Reviewable status: 73 of 82 files reviewed, all discussions resolved (waiting on @johlju)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 9 of 9 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved
Pull Request (PR) description
This PR updates the module to the new CI process and renames MSFT to DSC.
This Pull Request (PR) fixes the following issues
Task list
Entry should say what was changed, and how that affects users (if applicable).
and comment-based help.
@johlju - would you mind reviewing for me?
This change is