-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Apple Silicon) aarch64 OpenJDK detect and install #273
Conversation
Linking this pr to the old one if someone came across the old but not the new: #272 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, while I didn't tested the code (don't own any apple product), it seems alright
@r1tsuu I revised the logic a bit, look okay to you? I put in a note since I have to rewrite this as part of the assetguard 2 effort. I don't want to go too crazy on v1 and this seems like it would probably work. I don't have an m1 mac so I can't test. If you're good with it I'll merge. |
A little preview of some of the improvements we'll get from the rewritten code. https://github.com/dscalzi/helios-core/blob/40c568a6a9683b3f11815d9202375a0fa32f5623/lib/java/JavaGuard.ts#L315 |
On macOS with Apple Silicon processors ARM OpenJDK has ~100% perfomance boost over AMD64.
On the computer with ARM processor: