Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Apple Silicon processors #157

Closed
wants to merge 5 commits into from
Closed

Add support for Apple Silicon processors #157

wants to merge 5 commits into from

Conversation

GeekCornerGH
Copy link
Contributor

I saw we can build for new Apple Sillicon processors, so here you are @dscalzi

@GeekCornerGH
Add support for Apple Silicon processors
c04cbb5 
I saw we can build for new Apple Sillicon processors, so here you are
@GeekCornerGH
Forgot to change artifact name
9055fa9
@dscalzi
Copy link
Owner

dscalzi commented Apr 7, 2021 •
edited
Loading

What about the auto updater?

HeliosLauncher/app/assets/js/scripts/uicore.js

Line 51 in cb8d1bb

if(process.platform === 'darwin'){

dscalzi
dscalzi requested changes Apr 7, 2021
View reviewed changes
Copy link
Owner

@dscalzi dscalzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Autoupdater needs to be addressed.

@GeekCornerGH
Copy link
Contributor Author

Oh yeah I forgot that

@GeekCornerGH
Copy link
Contributor Author

@dscalzi Enjoy 😁

@coeragames
Copy link

coeragames commented Apr 8, 2021 •
edited
Loading

As its working for Apple Silicon processors, will it work with Rasberry Pi and other computers working with an ARM architecture ?

@GeekCornerGH
Copy link
Contributor Author

GeekCornerGH commented Apr 8, 2021 via email

@GeekCornerGH GeekCornerGH requested a review from dscalzi April 10, 2021 07:33
@GeekCornerGH
Copy link
Contributor Author

Also, lemme update Readme File

@GeekCornerGH
Copy link
Contributor Author

Ok, perfect 😁

dscalzi
dscalzi reviewed Apr 11, 2021
View reviewed changes
README.md Show resolved Hide resolved
@GeekCornerGH GeekCornerGH requested a review from dscalzi May 10, 2021 10:41
dscalzi added a commit that referenced this pull request May 14, 2021
@dscalzi
Add support for building arm64 dmg (Apple Silicon processors) (#157).
cd1ca7e
@dscalzi
Copy link
Owner

dscalzi commented May 14, 2021

Thanks, landed in cd1ca7e

@dscalzi dscalzi closed this May 14, 2021
ASCIIcat added a commit to ASCIIcat/AvalonConcordiaLauncher that referenced this pull request Aug 24, 2021
@ASCIIcat
Squashed commit of the following:
c29b839 
commit 3a301b2
Merge: 8eed153 54e6572
Author: Jay <[email protected]>
Date:   Tue Aug 24 16:26:59 2021 +0200

    Merge branch 'master' of https://github.com/dscalzi/HeliosLauncher into dscalzi-master

commit 54e6572
Author: Peter <[email protected]>
Date:   Mon Jul 19 16:08:55 2021 +0100

    Use MCHeads instead of Crafatar (dscalzi#181)

    * Update landing.js

    This changes the Skin/Avatar server displayed on the landing page to one that displays the hat layer which then features the skin correctly.

    * Create landing.js

    This changes the Skin/Avatar server displayed on the landing page to one that displays the hat layer which then features the skin correctly.

    * Updated remaining Crafatar URLS

    Changed Crafatar URLS to matching mc-heads url.

commit 79135f3
Author: ZaptoInc <[email protected]>
Date:   Mon Jul 19 07:40:28 2021 +0200

    Fixed broken links on the login page (dscalzi#159)

commit 31a51b8
Author: Daniel Scalzi <[email protected]>
Date:   Mon Jul 19 00:52:57 2021 -0400

    MIT license.

commit 84c13e6
Author: Daniel Scalzi <[email protected]>
Date:   Thu Jun 24 18:22:29 2021 -0400

    Update PackXZExtract.

commit 1b48ad5
Author: Daniel Scalzi <[email protected]>
Date:   Wed Jun 23 20:46:00 2021 -0400

    Revert discord-rpc.

commit 2c487f7
Author: Daniel Scalzi <[email protected]>
Date:   Wed Jun 23 20:27:04 2021 -0400

    Electron 13.

    Deleting drop-in mods seems to be broken. If you're having this issue,
    please comment on this issue so electron fixes it.. electron/electron#29598

commit 61dbabd
Author: Daniel Scalzi <[email protected]>
Date:   Thu May 13 22:34:37 2021 -0400

    Dependency upgrade.

commit cd1ca7e
Author: Daniel Scalzi <[email protected]>
Date:   Thu May 13 21:49:18 2021 -0400

    Add support for building arm64 dmg (Apple Silicon processors) (dscalzi#157).

commit be4a42b
Author: Daniel Scalzi <[email protected]>
Date:   Thu May 13 21:06:59 2021 -0400

    Use GitHub Actions for building, refactor the builder configuration.

commit 48d0c9e
Author: Daniel Scalzi <[email protected]>
Date:   Tue Mar 23 18:57:16 2021 -0400

    Dependency upgrade.

commit a9fa7c4
Author: Daniel Scalzi <[email protected]>
Date:   Sun Mar 7 11:24:00 2021 -0500

    Upgrade xcode, node version on travis.

commit cb8d1bb
Author: Daniel Scalzi <[email protected]>
Date:   Sun Mar 7 11:17:23 2021 -0500

    Electron 12, Node 14, dependency upgrade.

commit 2743585
Author: Daniel Scalzi <[email protected]>
Date:   Mon Feb 1 18:04:52 2021 -0500

    Dependency upgrade, fix status (dscalzi#138).

commit a6ca2e8
Author: Daniel Scalzi <[email protected]>
Date:   Wed Jan 20 11:03:20 2021 -0500

    Update executable names on README.

commit 779a9a5
Author: Daniel Scalzi <[email protected]>
Date:   Fri Dec 11 16:00:55 2020 -0500

    Dependency upgrade.

commit 8723a19
Author: Daniel Scalzi <[email protected]>
Date:   Wed Dec 9 20:06:10 2020 -0500

    Minecraft.net status works again, dependency upgrade.

commit c93d492
Author: Daniel Scalzi <[email protected]>
Date:   Mon Nov 16 23:11:24 2020 -0500

    Electron 11, workaround for main process debugging in VS Code.

commit d48abf4
Author: Daniel Scalzi <[email protected]>
Date:   Mon Nov 9 19:25:37 2020 -0500

    Dependency upgrade.

commit 3ea41b4
Author: Daniel Scalzi <[email protected]>
Date:   Wed Sep 16 13:49:10 2020 -0400

    Point to https mojang endpoint.

commit faa5f52
Author: Daniel Scalzi <[email protected]>
Date:   Sun Sep 13 13:42:34 2020 -0400

    v1.8.0

commit c0776dc
Author: Daniel Scalzi <[email protected]>
Date:   Sun Sep 13 13:35:49 2020 -0400

    Set broken mojang services to green until their API is fixed.

commit 25e7e5a
Author: Daniel Scalzi <[email protected]>
Date:   Sun Sep 13 03:05:08 2020 -0400

    Tweaks to Java discovery.

    Add AdoptOpenJDK directory to the file scan.
    Remove TLS reject unauthorized flag.
    Use async/await for the fs scan function. Code was originally wrote
    using fs and not fs-extra.

commit 17e36fa
Author: Daniel Scalzi <[email protected]>
Date:   Sun Sep 13 02:22:24 2020 -0400

    Return after rejection.

commit 2156099
Author: Daniel Scalzi <[email protected]>
Date:   Sun Sep 13 02:10:11 2020 -0400

    Electron 10.

commit 9a2c1fd
Author: Daniel Scalzi <[email protected]>
Date:   Tue Sep 8 21:25:19 2020 -0400

    Use corretto on macOS since they use an older version of Xcode. (dscalzi#70)

    Vendor name is now displayed above the selected Java version on the settings page. This is to allow for easier differentiation between versions (ex. Amazon Corretto vs AdoptOpenJDK).

commit cc86f2a
Author: Daniel Scalzi <[email protected]>
Date:   Sat Sep 5 22:43:09 2020 -0400

    Use --fml.modLists instead of --fml.mods to avoid potential cli length limit issues.

commit e6897da
Author: Daniel Scalzi <[email protected]>
Date:   Wed Sep 2 19:10:28 2020 -0400

    Dependency upgrade.

commit bd19b16
Author: Daniel Scalzi <[email protected]>
Date:   Tue Aug 25 17:11:40 2020 -0400

    Include user's displayName in server joined regex.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drdeee drdeee drdeee approved these changes

@dscalzi dscalzi Awaiting requested review from dscalzi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@GeekCornerGH @dscalzi @coeragames @drdeee