Skip to content

Commit

Permalink
Fix build with native dependencies. (#213)
Browse files Browse the repository at this point in the history
Build still fails on macOS, likely because the native dependency does not support arm64. Republished the dependency with the optional native components removed to solve the problem.
  • Loading branch information
dscalzi authored Jan 23, 2022
1 parent 9c6d75f commit c1d36d2
Show file tree
Hide file tree
Showing 3 changed files with 29 additions and 72 deletions.
20 changes: 13 additions & 7 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,16 +14,22 @@ jobs:
- name: Check out Git repository
uses: actions/checkout@v1

- name: Install Node.js, NPM and Yarn
- name: Set up Node
uses: actions/setup-node@v1
with:
node-version: 16

- name: Build/release Electron app
uses: samuelmeuli/action-electron-builder@v1
- name: Set up Python
uses: actions/setup-python@v2
with:
github_token: ${{ secrets.github_token }}
python-version: 3.x

# If the commit is tagged with a version (e.g. "v1.0.0"),
# release the app after building
release: ${{ startsWith(github.ref, 'refs/tags/v') }}
- name: Install Dependencies
run: npm ci
shell: bash

- name: Build
env:
GH_TOKEN: ${{ secrets.github_token }}
run: npm run dist
shell: bash
79 changes: 15 additions & 64 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
"@electron/remote": "^2.0.1",
"adm-zip": "^0.5.9",
"async": "^3.2.1",
"discord-rpc": "^3.2.0",
"discord-rpc-patch": "^4.0.1",
"ejs": "^3.1.6",
"ejs-electron": "^2.1.1",
"electron-updater": "^4.3.9",
Expand Down

0 comments on commit c1d36d2

Please sign in to comment.