Skip to content

Commit

Permalink
Update eletron to v15, target node 16 to match.
Browse files Browse the repository at this point in the history
  • Loading branch information
dscalzi committed Oct 15, 2021
1 parent 430e840 commit a2168da
Show file tree
Hide file tree
Showing 6 changed files with 9 additions and 12 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
- name: Install Node.js, NPM and Yarn
uses: actions/setup-node@v1
with:
node-version: 14
node-version: 16

- name: Build/release Electron app
uses: samuelmeuli/action-electron-builder@v1
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
14
16
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ This section details the setup of a basic developmentment environment.

**System Requirements**

* [Node.js][nodejs] v14
* [Node.js][nodejs] v16

---

Expand Down
3 changes: 0 additions & 3 deletions index.js
Original file line number Diff line number Diff line change
Expand Up @@ -88,9 +88,6 @@ ipcMain.on('distributionIndexDone', (event, res) => {
// https://electronjs.org/docs/tutorial/offscreen-rendering
app.disableHardwareAcceleration()

// https://github.com/electron/electron/issues/18397
app.allowRendererProcessReuse = true

// Keep a global reference of the window object, if you don't, the window will
// be closed automatically when the JavaScript object is garbage collected.
let win
Expand Down
8 changes: 4 additions & 4 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
"lint": "eslint --config .eslintrc.json ."
},
"engines": {
"node": "14.x.x"
"node": "16.x.x"
},
"dependencies": {
"@electron/remote": "^2.0.1",
Expand All @@ -40,7 +40,7 @@
"winreg": "^1.2.4"
},
"devDependencies": {
"electron": "^13.5.2",
"electron": "^15.2.0",
"electron-builder": "^22.13.1",
"eslint": "^8.0.1"
},
Expand Down

0 comments on commit a2168da

Please sign in to comment.