Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WEEK06 조영서] 스타일 가이드와 디자인 패턴 #57

Open
wants to merge 2 commits into
base: jjwm10625
Choose a base branch
from

Conversation

jjwm10625
Copy link
Contributor

✅ 𝗖𝗵𝗲𝗰𝗸-𝗟𝗶𝘀𝘁

  • merge할 브랜치의 위치를 확인해 주세요.
  • 리뷰어를 gaeulzzang으로 지정해 주세요.
  • Approve된 PR은 assigner가 머지하고, 수정 요청이 온 경우 수정 후 다시 push를 합니다.

📌 𝗜𝘀𝘀𝘂𝗲𝘀

📎 𝗪𝗼𝗿𝗸 𝗗𝗲𝘀𝗰𝗿𝗶𝗽𝘁𝗶𝗼𝗻

  • 폰트와 컬러 사용해서 UI 꾸미기
  • 디자인 패턴 뷰모델을 사용해서 코드 리팩토링

📷 𝗦𝗰𝗿𝗲𝗲𝗻𝘀𝗵𝗼𝘁

Screen_recording_20241111_204548.webm

💬 𝗧𝗼 𝗥𝗲𝘃𝗶𝗲𝘄𝗲𝗿𝘀

테마 컬러 변경했는데 왜 적용이 안되는지 모르겠습니다 ㅠ.ㅠ 어디가 문제인걸까요?

Copy link
Contributor

@gaeulzzang gaeulzzang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

6주차까지 너무 고생 많으셨습니다 💚

Comment on lines 36 to 51
val navController = rememberNavController()

// NavHost 설정
NavHost(
navController = navController,
startDestination = if (isLoggedIn) "main" else "login" // 자동 로그인 여부에 따라 시작 화면 설정
) {
composable("login") {
LoginPage(navController)
LoginPage(navController, mainViewModel)
}
composable("profile") {
ProfileScreen(navController)
composable("main") {
ProfileScreen(navController, mainViewModel)
}
composable("user") {
UserScreen(navController)
UserScreen(navController, mainViewModel)
}
composable("userCreate") {
UserCreateScreen(navController)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 코드 바깥을 GDGAndroidTheme으로 감싸야 테마가 적용될거에요!!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 코드 바깥을 GDGAndroidTheme으로 감싸야 테마가 적용될거에요!!

헉 그렇군요 !!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

직접 그리신건가요?ㅋㅋㅋㅋㅋㅋㅋ

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

직접 그리신건가요?ㅋㅋㅋㅋㅋㅋㅋ

아뇨 ㅋㅋㅋㅋㅋㅋㅋ 퍼왔습니다 ㅋㅋㅋㅋ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants