Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#25] fix: register event with eid #92

Merged
merged 4 commits into from
May 31, 2022
Merged

Conversation

raae7742
Copy link
Member

Description

  • Add Dockerfile
  • Fix register/event PUT api parameter
  • Refactor NoticeController, NoticeService

변경사항

  • register/event PUT 요청 시 파라미터 id => eid로 변경
  • register/event POST 요청 삭제
  • notice/ocr, notice/save에서 event가 아닌 sentence는 eid: -1을 반환하도록 함
  • NoticeService에서 detectEvent, extractSentenceFromEvent 통합

raae7742 added 3 commits May 31, 2022 14:29
- Refactor NoticeController, NoticeService
- Return eid -1 when sentence is not event
- Delete `/event/register` POST api
@raae7742 raae7742 added bug Something isn't working 🌱back-end Back-end labels May 31, 2022
@raae7742 raae7742 requested a review from hellouz818 May 31, 2022 06:15
@raae7742 raae7742 self-assigned this May 31, 2022
Copy link
Member

@hellouz818 hellouz818 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

화긴! 수고했어어 👍👍

@hellouz818 hellouz818 merged commit d8d2c62 into main May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱back-end Back-end bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants