Remove dependency on System.Linq.Async #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hold up, I didn't namespace the extension. I'll push an update. |
Added ToListAsync implementation to eliminate dependency on System.Linq.Async, which provided System.Linq.AsyncEnumerable.ToListAsync. System.Linq.Async introduces extension methods to a default (or even mandatory) namespace which conflict with other implementations, see: dotnet/reactive#1057
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
System.Linq.Async appears to be used exclusively to provide ToListAsync, which is ridiculous as it is trivial to implement.
It also introduces extension methods into the System.Linq namespace which conflict with common EntityFrameworkCore usage patterns, as DbSet<T> implements both IAsyncEnumerable<T> and IQueryable<T>. This most often manifests itself as a conflict between:
and
You can watch both Microsoft teams blame each other here:
dotnet/reactive#1057
dotnet/efcore#18124