-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(aws): upgrade to use non-deprecated attributes #256
Conversation
values = [var.nomad_api_domain] | ||
host-header { | ||
values = [var.nomad_api_domain] | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Documentation for new rule: https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/lb_listener_rule
Issue and when it was merged:
hashicorp/terraform-provider-aws#8126
stage_name = aws_api_gateway_deployment.api-gateway-deployment.stage_name | ||
api_stages { | ||
api_id = aws_api_gateway_rest_api.api-gateway.id | ||
stage = aws_api_gateway_deployment.api-gateway-deployment.stage_name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Documentation on switching to new rule: https://www.devopsschool.com/pdf/terraform/slides/Complete-Terraform-documentation/aws.pdf
e506021
to
23ed9a9
Compare
Can you help to add a provider versioning constraint on terraform {
required_providers {
aws = ">= 2.42"
}
} I chose the above version number based on first support for the new syntax, based on hashicorp/terraform-provider-aws#8126. Let me know if it's not correct? Ref: https://www.terraform.io/docs/configuration/providers.html#provider-versions |
Did a search through the codebase and updated all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update!
There was a recent change on removing deprecated attributes from the AWS
provider (see hashicorp/terraform-provider-aws#13398),
because the GitHub CI uses aws-provider v3.0.0, the builds would not pass
after the change.