Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aws): upgrade to use non-deprecated attributes #256

Merged
merged 2 commits into from
Aug 7, 2020

Conversation

qbiqing
Copy link
Contributor

@qbiqing qbiqing commented Aug 4, 2020

There was a recent change on removing deprecated attributes from the AWS
provider (see hashicorp/terraform-provider-aws#13398),
because the GitHub CI uses aws-provider v3.0.0, the builds would not pass
after the change.

values = [var.nomad_api_domain]
host-header {
values = [var.nomad_api_domain]
}
Copy link
Contributor Author

@qbiqing qbiqing Aug 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stage_name = aws_api_gateway_deployment.api-gateway-deployment.stage_name
api_stages {
api_id = aws_api_gateway_rest_api.api-gateway.id
stage = aws_api_gateway_deployment.api-gateway-deployment.stage_name
Copy link
Contributor Author

@qbiqing qbiqing Aug 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@qbiqing qbiqing changed the title fix(aws): upgrade to use non-deprecated syntax fix(aws): upgrade to use non-deprecated attributes Aug 4, 2020
@qbiqing qbiqing force-pushed the fix--upgrade-aws-provider-3.0-syntax branch from e506021 to 23ed9a9 Compare August 4, 2020 02:35
@qbiqing qbiqing requested a review from guangie88 August 4, 2020 02:38
@guangie88
Copy link
Collaborator

Can you help to add a provider versioning constraint on aws? Like this:

terraform {
  required_providers {
    aws = ">= 2.42"
  }
}

I chose the above version number based on first support for the new syntax, based on hashicorp/terraform-provider-aws#8126. Let me know if it's not correct?

Ref: https://www.terraform.io/docs/configuration/providers.html#provider-versions

@qbiqing
Copy link
Contributor Author

qbiqing commented Aug 5, 2020

Can you help to add a provider versioning constraint on aws? Like this:

terraform {
  required_providers {
    aws = ">= 2.42"
  }
}

I chose the above version number based on first support for the new syntax, based on terraform-providers/terraform-provider-aws#8126. Let me know if it's not correct?

Ref: https://www.terraform.io/docs/configuration/providers.html#provider-versions

Did a search through the codebase and updated all aws provider versions.

Copy link
Collaborator

@guangie88 guangie88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update!

@qbiqing qbiqing merged commit db52537 into master Aug 7, 2020
@qbiqing qbiqing deleted the fix--upgrade-aws-provider-3.0-syntax branch August 7, 2020 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants