Patch fails when created with v5 #36
Comments
|
Thanks for the report! Hope you don't mind answering a couple more questions:
|
Since the patch always applied fine locally, unfortunately I did not have the constitution to debug further on travis. My local git is 2.15 |
|
Thanks for those details. I'm going to look into this over the next week or so. Probably going to end up doing pure-JS patch application if I can. |
|
cool, I love this package btw! thank you. FWIW v3 is working great atm |
|
I think I'm having the same issue, but downgrading to v3 doesn't fix the problem for me: I get the following error after 'yarn': If I manually try to apply the patch with "git apply -v --ignore-whitespace patches/react-native-maps+0.19.0.patch": If I check AIRGoogleMapManager.m:32 the content it's looking for seems to be there, but it's still failing somehow... If I apply using GNU patch with --ignore-white-space/-l set it does apply (ignore me forgetting to specify it's a unified diff ;-)): |
|
Thanks for this @mauritsd — I should have some time this weekend to take a look at making the patch application js-based rather than using Git, which seems to have quite flaky behaviour across platforms and versions. |
|
I looked into doing pure-js patch application and I think it would be a lot of work and there would be a bunch of edge cases to deal with, some of which I'm probably not going to anticipate before publishing. Something I could do to mitigate this problem in the meantime would be to use |
|
That'd be fine; I'm also on macOS. Is there a definitive diagnosis as to why 'git apply' fails? I'll have a look at the patch file and the destination file with a hex editor... |
|
I've figured out why it fails in my particular instance. When patch-package generates the diff it specifies the --ignore-space-at-eol option to git-diff. Through testing I've found out that this, when coupled with indented lines without content (e.g. " \n"), will cause git-diff to generate patch files which are not accepted by git-apply, even with --ignore-whitespace and friends. If I remove the --ignore-space-at-eol option from patch-package the patch file is a bit less clean but does apply. Maybe an idea to allow the user to specify which git-diff options to use? |
|
Thanks for the investigation! Maybe I should just not use the
--ignore-space-at-eol flag? Allowing configuration of the git command would
let people solve these issues on their own, but man I'd love to have
something that just works for everyone. Feels like that *should* exist too.
…On Tue, 30 Jan 2018, 15:52 Maurits Dijkstra, ***@***.***> wrote:
I've figured out why it fails in my particular instance. When
patch-package generates the diff it specifies the --ignore-space-at-eol
option to git-diff. Through testing I've found out that this, when coupled
with indented lines without content (e.g. " \n"), will cause git-diff to
generate patch files which are not accepted by git-apply to fail, even with
--ignore-whitespace and friends. If I remove the --ignore-space-at-eol
option from patch-package the patch file is a bit less clean but does apply.
Maybe an idea to allow the user to specify which git-diff options to use?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#36 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABL1qdeMznUVIzjdwFoeG7peBX7TVN5Xks5tPzqfgaJpZM4Q-Wpv>
.
|
|
I think the 'right' course of action is to fix git-apply, but that's more of a long term solution... By the way, git-merge does have an option to ignore spaces at EOL (-Xignore-space-at-eol). |
|
Same issue here with v5 and CircleCI. Patches appear flaky from one build to another (e.g. it succeeds if I install packages on my local Mac using Yarn with EDIT: the problem reappears even when I regenerate the patch (either via |
|
Moreover, downgrading to v5.0.0 (which has been working for me for an entire month) does fix the problem. So it seems there might have been some regression in the last 2 releases (5.1.0/5.1.1). |
|
Thanks for the report. Weird that for you 5.1 is flaky but 5.0 is not. I didn't change the way As a temporary workaround you could call |
|
Hmm, I've just had this problem with 5.0 as well. Updated to 5.1.1 and now it works again! Not sure why it was misbehaving earlier - will update if anything changes again. Thanks |
|
😂 😩 Must find some time to fix this soon. Thanks for the update. |
|
I think it has something to do with caching of |
|
I'm having this bug. I have 4 old patches that work fine, but the 5th doesn't: LogSee npm logEnvmacOS 10.13.3 PatchSee full patch contentpatch-package
--- a/node_modules/react-native-camera/ios/FaceDetector/RNFaceDetectorManager.h
+++ b/node_modules/react-native-camera/ios/FaceDetector/RNFaceDetectorManager.h
@@ -8,13 +8,17 @@
#import <Foundation/Foundation.h>
#import <AVFoundation/AVFoundation.h>
+#if __has_include(<GoogleMobileVision/GoogleMobileVision.h>)
#import <GoogleMobileVision/GoogleMobileVision.h>
#import <GoogleMVDataOutput/GoogleMVDataOutput.h>
+#endif
+
@protocol RNFaceDetectorDelegate
- (void)onFacesDetected:(NSArray<NSDictionary *> *)faces;
@end
+#if __has_include(<GoogleMobileVision/GoogleMobileVision.h>)
@interface RNFaceDetectorManager : NSObject
- (NSDictionary *)constantsToExport;
@@ -31,3 +35,4 @@
- (void)stopFaceDetection;
@end
+#endif
--- a/node_modules/react-native-camera/ios/FaceDetector/RNFaceDetectorManager.m
+++ b/node_modules/react-native-camera/ios/FaceDetector/RNFaceDetectorManager.m
@@ -5,6 +5,7 @@
// Created by Joao Guilherme Daros Fidelis on 21/01/18.
//
+#if __has_include(<GoogleMobileVision/GoogleMobileVision.h>)
#import <React/RCTConvert.h>
#import "RNCamera.h"
#import "RNFaceEncoder.h"
@@ -272,3 +273,4 @@ static NSDictionary *defaultFaceDetectorOptions = nil;
}
@end
+#endif
--- a/node_modules/react-native-camera/ios/FaceDetector/RNFaceDetectorModule.h
+++ b/node_modules/react-native-camera/ios/FaceDetector/RNFaceDetectorModule.h
@@ -6,7 +6,9 @@
//
#import <React/RCTBridgeModule.h>
+#if __has_include(<GoogleMobileVision/GoogleMobileVision.h>)
#import <GoogleMobileVision/GoogleMobileVision.h>
+#endif
@interface RNFaceDetectorModule : NSObject <RCTBridgeModule>
@end
--- a/node_modules/react-native-camera/ios/FaceDetector/RNFaceDetectorModule.m
+++ b/node_modules/react-native-camera/ios/FaceDetector/RNFaceDetectorModule.m
@@ -5,6 +5,7 @@
// Created by Joao Guilherme Daros Fidelis on 21/01/18.
//
+#if __has_include(<GoogleMobileVision/GoogleMobileVision.h>)
#import "RNFaceDetectorModule.h"
#import "RNFaceEncoder.h"
#import "RNFileSystem.h"
@@ -193,3 +194,4 @@ RCT_EXPORT_METHOD(detectFaces:(nonnull NSDictionary *)options
}
@end
+#endif
--- a/node_modules/react-native-camera/ios/FaceDetector/RNFaceDetectorUtils.h
+++ b/node_modules/react-native-camera/ios/FaceDetector/RNFaceDetectorUtils.h
@@ -5,6 +5,7 @@
// Created by Joao Guilherme Daros Fidelis on 21/01/18.
//
+#if __has_include(<GoogleMobileVision/GoogleMobileVision.h>)
#import <UIKit/UIKit.h>
#import <CoreMedia/CoreMedia.h>
#import <Foundation/Foundation.h>
@@ -33,3 +34,4 @@ typedef NS_ENUM(NSInteger, RNFaceDetectionClassifications) {
+ (CGAffineTransform)transformFromDeviceOutput:(GMVDataOutput *)dataOutput toInterfaceVideoOrientation:(AVCaptureVideoOrientation)interfaceVideoOrientation;
@end
+#endif
--- a/node_modules/react-native-camera/ios/FaceDetector/RNFaceDetectorUtils.m
+++ b/node_modules/react-native-camera/ios/FaceDetector/RNFaceDetectorUtils.m
@@ -5,6 +5,7 @@
// Created by Joao Guilherme Daros Fidelis on 21/01/18.
//
+#if __has_include(<GoogleMobileVision/GoogleMobileVision.h>)
#import "RNCameraUtils.h"
#import "RNFaceDetectorUtils.h"
#import "RNFaceDetectorPointTransformCalculator.h"
@@ -75,3 +76,4 @@ NSString *const RNGMVDataOutputHeightKey = @"Height";
}
@end
+#endif
--- a/node_modules/react-native-camera/ios/FaceDetector/RNFaceEncoder.h
+++ b/node_modules/react-native-camera/ios/FaceDetector/RNFaceEncoder.h
@@ -6,6 +6,7 @@
//
#import <UIKit/UIKit.h>
+#if __has_include(<GoogleMobileVision/GoogleMobileVision.h>)
#import <GoogleMobileVision/GoogleMobileVision.h>
@interface RNFaceEncoder : NSObject
@@ -15,3 +16,4 @@
- (NSDictionary *)encode:(GMVFaceFeature *)face;
@end
+#endif
--- a/node_modules/react-native-camera/ios/FaceDetector/RNFaceEncoder.m
+++ b/node_modules/react-native-camera/ios/FaceDetector/RNFaceEncoder.m
@@ -7,6 +7,7 @@
#import "RNFaceEncoder.h"
+#if __has_include(<GoogleMobileVision/GoogleMobileVision.h>)
#define cDefaultFloatComparisonEpsilon 0.0001
#define cModEqualFloatsWithEpsilon(dividend, divisor, modulo, epsilon) \
fabs( fmod(dividend, divisor) - modulo ) < epsilon
@@ -117,3 +118,4 @@ cModEqualFloatsWithEpsilon(dividend, divisor, modulo, cDefaultFloatComparisonEps
}
@end
+#endif
--- a/node_modules/react-native-camera/ios/RN/RNCamera.m
+++ b/node_modules/react-native-camera/ios/RN/RNCamera.m
@@ -284,6 +284,7 @@ static NSDictionary *defaultFaceDetectorOptions = nil;
[device unlockForConfiguration];
}
+#if __has_include(<GoogleMobileVision/GoogleMobileVision.h>)
- (void)updateFaceDetecting:(id)faceDetecting
{
[_faceDetectorManager setIsEnabled:faceDetecting];
@@ -303,6 +304,7 @@ static NSDictionary *defaultFaceDetectorOptions = nil;
{
[_faceDetectorManager setClassificationsDetected:requestedClassifications];
}
+#endif
- (void)takePicture:(NSDictionary *)options resolve:(RCTPromiseResolveBlock)resolve reject:(RCTPromiseRejectBlock)reject
{
@@ -382,7 +384,9 @@ static NSDictionary *defaultFaceDetectorOptions = nil;
// At the time of writing AVCaptureMovieFileOutput and AVCaptureVideoDataOutput (> GMVDataOutput)
// cannot coexist on the same AVSession (see: https://stackoverflow.com/a/4986032/1123156).
// We stop face detection here and restart it in when AVCaptureMovieFileOutput finishes recording.
+#if __has_include(<GoogleMobileVision/GoogleMobileVision.h>)
[_faceDetectorManager stopFaceDetection];
+#endif
[self setupMovieFileCapture];
}
@@ -443,7 +447,9 @@ static NSDictionary *defaultFaceDetectorOptions = nil;
self.stillImageOutput = stillImageOutput;
}
+#if __has_include(<GoogleMobileVision/GoogleMobileVision.h>)
[_faceDetectorManager maybeStartFaceDetectionOnSession:_session withPreviewLayer:_previewLayer];
+#endif
[self setupOrDisableBarcodeScanner];
__weak RNCamera *weakSelf = self;
@@ -469,7 +475,9 @@ static NSDictionary *defaultFaceDetectorOptions = nil;
return;
#endif
dispatch_async(self.sessionQueue, ^{
+#if __has_include(<GoogleMobileVision/GoogleMobileVision.h>)
[_faceDetectorManager stopFaceDetection];
+#endif
[self.previewLayer removeFromSuperlayer];
[self.session commitConfiguration];
[self.session stopRunning];
@@ -722,9 +730,12 @@ static NSDictionary *defaultFaceDetectorOptions = nil;
self.videoRecordedReject = nil;
[self cleanupMovieFileCapture];
+
+#if __has_include(<GoogleMobileVision/GoogleMobileVision.h>)
// If face detection has been running prior to recording to file
// we reenable it here (see comment in -record).
[_faceDetectorManager maybeStartFaceDetectionOnSession:_session withPreviewLayer:_previewLayer];
+#endif
if (self.session.sessionPreset != AVCaptureSessionPresetHigh) {
[self updateSessionPreset:AVCaptureSessionPresetHigh];
@@ -738,11 +749,13 @@ static NSDictionary *defaultFaceDetectorOptions = nil;
Class faceDetectorManagerClass = NSClassFromString(@"RNFaceDetectorManager");
Class faceDetectorManagerStubClass = NSClassFromString(@"RNFaceDetectorManagerStub");
+#if __has_include(<GoogleMobileVision/GoogleMobileVision.h>)
if (faceDetectorManagerClass) {
return [[faceDetectorManagerClass alloc] initWithSessionQueue:_sessionQueue delegate:self];
} else if (faceDetectorManagerStubClass) {
return [[faceDetectorManagerStubClass alloc] init];
}
+#endif
return nil;
}
--- a/node_modules/react-native-camera/ios/RN/RNCameraManager.m
+++ b/node_modules/react-native-camera/ios/RN/RNCameraManager.m
@@ -86,11 +86,15 @@ RCT_EXPORT_VIEW_PROPERTY(onFacesDetected, RCTDirectEventBlock);
+ (NSDictionary *)faceDetectorConstants
{
+#if __has_include(<GoogleMobileVision/GoogleMobileVision.h>)
#if __has_include("RNFaceDetectorManager.h")
return [RNFaceDetectorManager constants];
#else
return [RNFaceDetectorManagerStub constants];
#endif
+#else
+ return [NSDictionary new];
+#endif
}
RCT_CUSTOM_VIEW_PROPERTY(type, NSInteger, RNCamera)
new file mode 100644
--- /dev/null
+++ b/node_modules/react-native-camera/ios/RNCamera.xcodeproj/xcuserdata/brunolemos.xcuserdatad/xcschemes/xcschememanagement.plist
@@ -0,0 +1,14 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
+<plist version="1.0">
+<dict>
+ <key>SchemeUserState</key>
+ <dict>
+ <key>RNCamera.xcscheme</key>
+ <dict>
+ <key>orderHint</key>
+ <integer>55</integer>
+ </dict>
+ </dict>
+</dict>
+</plist>
old mode 100644
new mode 100755
old mode 100644
new mode 100755
--- a/node_modules/react-native-camera/src/RNCamera.js
+++ b/node_modules/react-native-camera/src/RNCamera.js
@@ -106,9 +106,9 @@ export default class Camera extends React.Component<PropsType> {
flashMode: CameraManager.FlashMode,
autoFocus: CameraManager.AutoFocus,
whiteBalance: CameraManager.WhiteBalance,
- faceDetectionMode: CameraManager.FaceDetection.Mode,
- faceDetectionLandmarks: CameraManager.FaceDetection.Landmarks,
- faceDetectionClassifications: CameraManager.FaceDetection.Classifications,
+ faceDetectionMode: (CameraManager.FaceDetection || {}).Mode,
+ faceDetectionLandmarks: (CameraManager.FaceDetection || {}).Landmarks,
+ faceDetectionClassifications: (CameraManager.FaceDetection || {}).Classifications,
};
static propTypes = {
@@ -144,10 +144,10 @@ export default class Camera extends React.Component<PropsType> {
autoFocus: CameraManager.AutoFocus.on,
flashMode: CameraManager.FlashMode.off,
whiteBalance: CameraManager.WhiteBalance.auto,
- faceDetectionMode: CameraManager.FaceDetection.fast,
+ faceDetectionMode: (CameraManager.FaceDetection || {}).fast,
barCodeTypes: Object.values(CameraManager.BarCodeType),
- faceDetectionLandmarks: CameraManager.FaceDetection.Landmarks.none,
- faceDetectionClassifications: CameraManager.FaceDetection.Classifications.none,
+ faceDetectionLandmarks: ((CameraManager.FaceDetection || {}).Landmarks || {}).none,
+ faceDetectionClassifications: ((CameraManager.FaceDetection || {}).Classifications || {}).none,
permissionDialogTitle: '',
permissionDialogMessage: '',
notAuthorizedView: (
old mode 100644
new mode 100755
old mode 100644
new mode 100755InvestigationAfter further investigation, this is the part causing the problem:See problematic patch content--- a/node_modules/react-native-camera/ios/RN/RNCamera.m
+++ b/node_modules/react-native-camera/ios/RN/RNCamera.m
@@ -284,6 +284,7 @@ static NSDictionary *defaultFaceDetectorOptions = nil;
[device unlockForConfiguration];
}
+#if __has_include(<GoogleMobileVision/GoogleMobileVision.h>)
- (void)updateFaceDetecting:(id)faceDetecting
{
[_faceDetectorManager setIsEnabled:faceDetecting];
@@ -303,6 +304,7 @@ static NSDictionary *defaultFaceDetectorOptions = nil;
{
[_faceDetectorManager setClassificationsDetected:requestedClassifications];
}
+#endif
- (void)takePicture:(NSDictionary *)options resolve:(RCTPromiseResolveBlock)resolve reject:(RCTPromiseRejectBlock)reject
{
@@ -382,7 +384,9 @@ static NSDictionary *defaultFaceDetectorOptions = nil;
// At the time of writing AVCaptureMovieFileOutput and AVCaptureVideoDataOutput (> GMVDataOutput)
// cannot coexist on the same AVSession (see: https://stackoverflow.com/a/4986032/1123156).
// We stop face detection here and restart it in when AVCaptureMovieFileOutput finishes recording.
+#if __has_include(<GoogleMobileVision/GoogleMobileVision.h>)
[_faceDetectorManager stopFaceDetection];
+#endif
[self setupMovieFileCapture];
}
@@ -443,7 +447,9 @@ static NSDictionary *defaultFaceDetectorOptions = nil;
self.stillImageOutput = stillImageOutput;
}
+#if __has_include(<GoogleMobileVision/GoogleMobileVision.h>)
[_faceDetectorManager maybeStartFaceDetectionOnSession:_session withPreviewLayer:_previewLayer];
+#endif
[self setupOrDisableBarcodeScanner];
__weak RNCamera *weakSelf = self;
@@ -469,7 +475,9 @@ static NSDictionary *defaultFaceDetectorOptions = nil;
return;
#endif
dispatch_async(self.sessionQueue, ^{
+#if __has_include(<GoogleMobileVision/GoogleMobileVision.h>)
[_faceDetectorManager stopFaceDetection];
+#endif
[self.previewLayer removeFromSuperlayer];
[self.session commitConfiguration];
[self.session stopRunning];
@@ -722,9 +730,12 @@ static NSDictionary *defaultFaceDetectorOptions = nil;
self.videoRecordedReject = nil;
[self cleanupMovieFileCapture];
+
+#if __has_include(<GoogleMobileVision/GoogleMobileVision.h>)
// If face detection has been running prior to recording to file
// we reenable it here (see comment in -record).
[_faceDetectorManager maybeStartFaceDetectionOnSession:_session withPreviewLayer:_previewLayer];
+#endif
if (self.session.sessionPreset != AVCaptureSessionPresetHigh) {
[self updateSessionPreset:AVCaptureSessionPresetHigh];
@@ -738,11 +749,13 @@ static NSDictionary *defaultFaceDetectorOptions = nil;
Class faceDetectorManagerClass = NSClassFromString(@"RNFaceDetectorManager");
Class faceDetectorManagerStubClass = NSClassFromString(@"RNFaceDetectorManagerStub");
+#if __has_include(<GoogleMobileVision/GoogleMobileVision.h>)
if (faceDetectorManagerClass) {
return [[faceDetectorManagerClass alloc] initWithSessionQueue:_sessionQueue delegate:self];
} else if (faceDetectorManagerStubClass) {
return [[faceDetectorManagerStubClass alloc] init];
}
+#endif
return nil;
}
You can compare with the pull request and see some numbers are off. |
|
I made the changes again on the file above, this time it decided to work 🤔
See new generated patch--- a/node_modules/react-native-camera/ios/RN/RNCamera.m
+++ b/node_modules/react-native-camera/ios/RN/RNCamera.m
@@ -284,6 +284,7 @@ static NSDictionary *defaultFaceDetectorOptions = nil;
[device unlockForConfiguration];
}
+#if __has_include(<GoogleMobileVision/GoogleMobileVision.h>)
- (void)updateFaceDetecting:(id)faceDetecting
{
[_faceDetectorManager setIsEnabled:faceDetecting];
@@ -303,6 +304,7 @@ static NSDictionary *defaultFaceDetectorOptions = nil;
{
[_faceDetectorManager setClassificationsDetected:requestedClassifications];
}
+#endif
- (void)takePicture:(NSDictionary *)options resolve:(RCTPromiseResolveBlock)resolve reject:(RCTPromiseRejectBlock)reject
{
@@ -382,7 +384,9 @@ static NSDictionary *defaultFaceDetectorOptions = nil;
// At the time of writing AVCaptureMovieFileOutput and AVCaptureVideoDataOutput (> GMVDataOutput)
// cannot coexist on the same AVSession (see: https://stackoverflow.com/a/4986032/1123156).
// We stop face detection here and restart it in when AVCaptureMovieFileOutput finishes recording.
+#if __has_include(<GoogleMobileVision/GoogleMobileVision.h>)
[_faceDetectorManager stopFaceDetection];
+#endif
[self setupMovieFileCapture];
}
@@ -443,7 +447,9 @@ static NSDictionary *defaultFaceDetectorOptions = nil;
self.stillImageOutput = stillImageOutput;
}
+#if __has_include(<GoogleMobileVision/GoogleMobileVision.h>)
[_faceDetectorManager maybeStartFaceDetectionOnSession:_session withPreviewLayer:_previewLayer];
+#endif
[self setupOrDisableBarcodeScanner];
__weak RNCamera *weakSelf = self;
@@ -469,7 +475,9 @@ static NSDictionary *defaultFaceDetectorOptions = nil;
return;
#endif
dispatch_async(self.sessionQueue, ^{
+#if __has_include(<GoogleMobileVision/GoogleMobileVision.h>)
[_faceDetectorManager stopFaceDetection];
+#endif
[self.previewLayer removeFromSuperlayer];
[self.session commitConfiguration];
[self.session stopRunning];
@@ -722,9 +730,11 @@ static NSDictionary *defaultFaceDetectorOptions = nil;
self.videoRecordedReject = nil;
[self cleanupMovieFileCapture];
+#if __has_include(<GoogleMobileVision/GoogleMobileVision.h>)
// If face detection has been running prior to recording to file
// we reenable it here (see comment in -record).
[_faceDetectorManager maybeStartFaceDetectionOnSession:_session withPreviewLayer:_previewLayer];
+#endif
if (self.session.sessionPreset != AVCaptureSessionPresetHigh) {
[self updateSessionPreset:AVCaptureSessionPresetHigh];
@@ -738,11 +748,13 @@ static NSDictionary *defaultFaceDetectorOptions = nil;
Class faceDetectorManagerClass = NSClassFromString(@"RNFaceDetectorManager");
Class faceDetectorManagerStubClass = NSClassFromString(@"RNFaceDetectorManagerStub");
+#if __has_include(<GoogleMobileVision/GoogleMobileVision.h>)
if (faceDetectorManagerClass) {
return [[faceDetectorManagerClass alloc] initWithSessionQueue:_sessionQueue delegate:self];
} else if (faceDetectorManagerStubClass) {
return [[faceDetectorManagerStubClass alloc] init];
}
+#endif
return nil;
}How to prevent this from happening again? |
|
I was also having this issue. I tried downgrading versions and all kinds of things which didn't work. Removing the cache key and all the lines it included from travis.yml resolved the problem. Here is the full list of steps I took before reaching this solution:
I think the step to delete the original patch may not have been necessary, but I am not entirely sure. Definitely the step for patch #2 was not useful. I hope any of this helps anyone else having this issue. |
|
FWIW, not sure if the same could be done in Travis, but in CircleCI it's easy enough to update the cache key by just adding a number to it, like so: - restore_cache:
keys:
- cache-{{ checksum "yarn.lock" }}-1
- cache-One can always just increment the number if the cache key needs to be busted again. Hope that helps. |
|
Thanks for the detailed tips Liisa!
Update for this thread: Last night I made a lot of progress working on
custom pure-TypeScript patch application. That will make these errors go
away soon.
…On Thu, 22 Mar 2018, 08:28 Liisa Duerig-Laitinen, ***@***.***> wrote:
I'll keep that in mind next time around, thanks for the tip @dinvlad
<https://github.com/dinvlad>.
I hope this issue finds a solution, this is an incredibly useful module.
@ds300 <https://github.com/ds300> , thanks so much for the great work on
this!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#36 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABL1qQEqCsTc1vKjkVYxBta0f7MbmAKmks5tg2CXgaJpZM4Q-Wpv>
.
|
|
Another update for this thread: You can try out the 6.0.0-X pre-release builds, which use the new TS-only patch application (yay! no more |
|
Oh no. Apparently the publish didn't go through last night. Should work now. or |
|
@ds300 I was having the same issue and for now, I can confirm the beta works :) |
|
@ds300 The @beta is pointing to this version (and I guess the good one is v6.0.0-3): https://github.com/ds300/patch-package/releases/tag/v3.5.3-0 |
|
Weird, for me it's pointing to the correct one, v6.0.0-3
Are you using yarn or npm? |
|
Also this: |
|
@ds300 Maybe it's because we are behind a private npm repo but we (both of us) only have the chance to install up to 5.1.1. Please, ignore this if we are the only ones reporting the problem. Update: indeed it was, fixed now by our internal IT team =) |
|
Is this fixed and can it be closed? |
|
Yes! It is fixed in |
|
i'm getting the same with a patch that was supposedly working for over a month, nothing updated that i know of... v5.1.1 |
|
This problem also occurs when someone creates a patch with npm/npx and his colleague tries to apply the patch with Yarn.. Maybe we can implement a notice for such a human problems in the fail message? |
I get the following
when CI tries to apply the patch that I created locally (OSX) with patch package 5. Downgrading to v3 resolves the issue.
The text was updated successfully, but these errors were encountered: