Add Collect creator method data from Europeana API (Fixes WordPress#2834

)
dryruffian · Oct 26, 2024 · 38d982c · 38d982c
1 parent 7e72f13
commit 38d982c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 7 deletions.
diff --git a/catalog/dags/providers/provider_api_scripts/europeana.py b/catalog/dags/providers/provider_api_scripts/europeana.py
@@ -163,7 +163,7 @@ def _get_creator(self, data: dict) -> str | None:
         if isinstance(creators, list):
             if not creators:  # Explicitly handle empty list
                 return None
-            return ", ".join(creators)
+            return ",".join(creators)
         elif isinstance(creators, str):
             return creators
         return None

diff --git a/catalog/tests/dags/providers/provider_api_scripts/test_europeana.py b/catalog/tests/dags/providers/provider_api_scripts/test_europeana.py
@@ -186,11 +186,8 @@ def test_record_builder_get_record_data(ingester, record_builder):
         "description": "Sello en seco: España artística y monumental.",
     }
 
-    expected_creator = (
-        "http://hispana.mcu.es/lod/oai:bibliotecadigital.jcyl.es:26229#ent2, "
-        "http://hispana.mcu.es/lod/oai:bibliotecadigital.jcyl.es:26229#ent3, "
-        "http://hispana.mcu.es/lod/oai:bibliotecadigital.jcyl.es:26229#ent4"
-    )
+    expected_creator = "http://hispana.mcu.es/lod/oai:bibliotecadigital.jcyl.es:26229#ent2,http://hispana.mcu.es/lod/oai:bibliotecadigital.jcyl.es:26229#ent3,http://hispana.mcu.es/lod/oai:bibliotecadigital.jcyl.es:26229#ent4"
+
 
     assert record_data == {
         "foreign_landing_url": (
@@ -299,7 +296,7 @@ def test_get_image_dimensions(item_data, expected, record_builder):
         # Multiple creators in a list
         pytest.param(
             {"dcCreator": ["Chandler", "Joey"]},
-            "Chandler, Joey",
+            "Chandler,Joey",
             id="multiple_creators",
         ),
         # Empty creator list