Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use pipefail in a step with a pipe #57

Merged
merged 1 commit into from
Jul 26, 2022

Conversation

benknoble
Copy link
Collaborator

Summary of Changes

This is supposed to be the default according to
https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_id_stepsshell
but actions/runner#353 indicates that this is
still not really the case (but the end result is confusing), so we'll
be explicit here.

This might solve #56

Public Domain Dedication

  • In contributing, I relinquish any copyright claims on my contribution and freely release it into the public domain in the simple hope that it will provide value.

(Why: The freely released, copyright-free work in this repository represents an investment in a better way of doing things called attribution-based economics. Attribution-based economics is based on the simple idea that we gain more by giving more, not by holding on to things that, truly, we could only create because we, in our turn, received from others. As it turns out, an economic system based on attribution -- where those who give more are more empowered -- is significantly more efficient than capitalism while also being stable and fair (unlike capitalism, on both counts), giving it transformative power to elevate the human condition and address the problems that face us today along with a host of others that have been intractable since the beginning. You can help make this a reality by releasing your work in the same way -- freely into the public domain in the simple hope of providing value. Learn more about attribution-based economics at drym.org, tell your friends, do your part.)

This is _supposed_ to be the default according to
https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_id_stepsshell
but actions/runner#353 indicates that this is
_still_ not really the case (but the end result is confusing), so we'll
be explicit here.
@countvajhula
Copy link
Collaborator

Yeah, those docs do say that bash is "The default shell on non-Windows platforms with a fallback to sh", and that bash --noprofile --norc -eo pipefail {0} is the command run internally for this shell.

The last comment on actions/runner#353 also suggests that "hosted runners" should run bash as expected, and I assume the runners for the Qi repo are hosted rather than self-hosted. So, it certainly sounds like it should be the default behavior but isn't.

This looks good to me, and thanks!

@countvajhula countvajhula merged commit c9f02dd into drym-org:main Jul 26, 2022
@benknoble benknoble deleted the fix-benchmarks-failure branch July 27, 2022 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants