Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always cache config values #157

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 22 additions & 1 deletion lib/dry/view.rb
Original file line number Diff line number Diff line change
Expand Up @@ -34,14 +34,35 @@ module Dry
#
# @api public
class View
class Config < Dry::Configurable::Config
# When the superclass returns a value, it only caches it to _values if it
# is considered "cloneable". The high frequency in which Dry::View calls
# this method, however, has considerable performance implications and, as
# such, as values are cached
#
# @see Dry::Configurable::Config#[]
#
# @param [String,Symbol] name
#
# @return Config value
def [](name)
name = name.to_sym
return _values[name] if _values.key?(name)

super
_values[name] = _settings[name].to_value unless _values.key?(name)
_values[name]
end
end

# @api private
DEFAULT_RENDERER_OPTIONS = {default_encoding: "utf-8"}.freeze

include Dry::Equalizer(:config, :exposures)

extend Dry::Core::Cache

extend Dry::Configurable
extend Dry::Configurable(config_class: Dry::View::Config)

# @!group Configuration

Expand Down