Fixes behavior of []
method for optional key
#177
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It fixes #171
Few notes about this fix:
@attributes
are already validated, so no need to go to schema and check if given key is actually optional@attributes
variable at the moment of creating object to make sure that behavior is consistent across access methods, hash syntax ([]
) and methodsattributes
,to_h
andto_hash
. Currentlyattributes
,to_h
andto_hash
methods don't not return missing keys. But I'm not sure if it's reasonable behavior change (maybe someone relies on current behavior). Pls let me know if you feel so and I will extend this PR (or will open another one)