Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(#682): update circleci node image #683

Merged
merged 2 commits into from
Nov 5, 2023
Merged

Conversation

Decipher
Copy link
Member

@Decipher Decipher commented Nov 5, 2023

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Update CircleCI Node image

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

Screenshots/Media:

Summary by CodeRabbit

  • Chores
    • Updated the Docker image used in our continuous integration process, which includes newer versions of Node.js and its dependencies.

Copy link

changeset-bot bot commented Nov 5, 2023

⚠️ No Changeset found

Latest commit: f890e5f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

coderabbitai bot commented Nov 5, 2023

Walkthrough

The primary change in this update is the modification of the Docker image used in the CircleCI configuration file. The image has been updated from "circleci/node:15.14" to "cimg/node:16.20.2", which likely includes newer versions of Node.js and its dependencies.

Changes

File Summary
.circleci/config.yml The Docker image used in the CircleCI configuration file has been updated from "circleci/node:15.14" to "cimg/node:16.20.2".

🐇🍂

In the season of fall, when leaves start to twirl,
Our code takes a leap, gives a whirl.
With Node.js updated, in Docker encapsulated,
Our CircleCI config, freshly recalibrated.

The trees may shed leaves, but we're gaining more power,
Optimizing our code, every day, every hour.
So here's to the changes, may they make our code lighter,
And the future of our project, ever brighter. 🌟


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai help to get help.
  • @coderabbitai resolve to resolve all the CodeRabbit review comments.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between f8c6b57 and edf3de3.
Files selected for processing (1)
  • .circleci/config.yml (1 hunks)
Files skipped from review due to trivial changes (1)
  • .circleci/config.yml

Copy link

codecov bot commented Nov 5, 2023

Codecov Report

Merging #683 (f890e5f) into develop (33f1fa5) will increase coverage by 0.14%.
Report is 55 commits behind head on develop.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #683      +/-   ##
===========================================
+ Coverage    96.00%   96.14%   +0.14%     
===========================================
  Files           86       91       +5     
  Lines         2275     2362      +87     
  Branches       469      509      +40     
===========================================
+ Hits          2184     2271      +87     
  Misses          76       76              
  Partials        15       15              
Files Coverage Δ
packages/druxt/src/components/DruxtWrapper.vue 100.00% <ø> (ø)
packages/views/src/components/DruxtView.vue 100.00% <ø> (ø)

... and 73 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@Decipher
Copy link
Member Author

Decipher commented Nov 5, 2023

@coderabbitai review

@Decipher Decipher merged commit 7c282de into develop Nov 5, 2023
9 checks passed
@Decipher Decipher deleted the feature/682-circle_ci branch November 5, 2023 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant