Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(#293): move Druxt Views nuxt module files #400

Merged
merged 2 commits into from
Dec 8, 2021
Merged

Conversation

Decipher
Copy link
Member

@Decipher Decipher commented Dec 8, 2021

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other

Description

  • Moved the Nuxt module files into a nuxt directory.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

Screenshots/Media:

@Decipher Decipher added the module: views Related to the `druxt-views` module label Dec 8, 2021
@changeset-bot
Copy link

changeset-bot bot commented Dec 8, 2021

⚠️ No Changeset found

Latest commit: ef23254

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented Dec 8, 2021

Codecov Report

Merging #400 (ef23254) into develop (9c4663a) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #400      +/-   ##
===========================================
- Coverage    96.91%   96.89%   -0.03%     
===========================================
  Files           89       88       -1     
  Lines         2886     2864      -22     
  Branches       626      621       -5     
===========================================
- Hits          2797     2775      -22     
  Misses          81       81              
  Partials         8        8              
Impacted Files Coverage Δ
packages/views/src/nuxt/storybook.js 97.95% <ø> (ø)
packages/views/src/index.js 96.29% <100.00%> (+0.14%) ⬆️
packages/views/src/nuxt/index.js 100.00% <100.00%> (ø)
packages/router/src/nuxt/index.js

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c4663a...ef23254. Read the comment docs.

@Decipher
Copy link
Member Author

Decipher commented Dec 8, 2021

Code coverage has gone down as there are less lines due to this commit, so nothing is less covered.

@Decipher Decipher merged commit d9d1d12 into develop Dec 8, 2021
@Decipher Decipher deleted the feature/293-views branch December 8, 2021 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: views Related to the `druxt-views` module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant