Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the mariadb executable for SQL commands where possible #6128

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

codebymikey
Copy link
Contributor

On newer versions of MariaDB e.g. 11.4.3, the following warning is shown:

mysql: Deprecated program name. It will be removed in a future release, use '/usr/bin/mariadb' instead

@weitzman
Copy link
Member

weitzman commented Oct 7, 2024

Thanks. Can we not count on mariadb existing? Mysql and postgres count on their program existing.

@codebymikey
Copy link
Contributor Author

I did think that, but did it this way to maintain as much backwards compatibility as possible just like the dump command does.

Based off the MariaDB documentation:

Prior to MariaDB 10.5, the client used to be called mysql, and can still be accessed under this name, via a symlink in Linux, or an alternate binary in Windows.

Drupal 10 currently requires MariaDB 10.3.7+ and can confirm from a quick test in docker lab, the mariadb binary only started being included around 10.4 despite what the doc says:

~$ docker run -it --rm mariadb:10.3.7 /bin/sh -c 'which mariadb'
~$ docker run -it --rm mariadb:10.4 /bin/sh -c 'which mariadb'
/usr/bin/mariadb

So the executable check will need to be removed once support for MariaDB <10.5 is dropped.

@weitzman weitzman merged commit 5432b85 into drush-ops:13.x Oct 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants