Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3423. Allow custom target dir for config:pull #3436

Merged
merged 2 commits into from
Mar 6, 2018

Conversation

weitzman
Copy link
Member

@weitzman weitzman commented Mar 6, 2018

No description provided.

@geek-merlin
Copy link
Contributor

Code looks straightforward what i wished for. 😍😍😍

Reusing known concepts of rsync path style, yeah!
Will test as soon as my tight schedule allows.

Just an idea: For the path example, we might use drupal-project-template's standard of @self:../config/sync.

@weitzman weitzman merged commit 7968a59 into master Mar 6, 2018
@weitzman weitzman deleted the config-pull-custom-target-path branch March 6, 2018 14:58
@weitzman
Copy link
Member Author

weitzman commented Mar 6, 2018

Improved that example and merged. Thanks.

@geek-merlin
Copy link
Contributor

Thank you for this quick implementation.

(Not wanting to be greedy, but) has this a chance of a D8 backport? Or is that branch frozen?
(I don't like the situation, but with a plethora of legacy, i'll be stuck on that version for a handful of projects for some time still.)

@weitzman
Copy link
Member Author

weitzman commented Mar 6, 2018 via email

@geek-merlin
Copy link
Contributor

OK cool. I'll scratch if the itching urges!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants