Use cbf to make tests/ PSR2 compliant. #3152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weitzman
commented
Nov 8, 2017
tests/annotatedCommandTest.php
Outdated
| 'name' => 'foo', | ||
| 'machine_name' => 'bar', | ||
| ]); | ||
| $optionsExample['directory'] = self::getSandbox(); |
There was a problem hiding this comment.
Anyone know if we can convince phpcs to preserve indentation on these array elements?
|
In general, I am against style-checking the tests. It's fine to run cbf on them to make them comply, but I usually don't make test style variations failures. I know plenty of projects that do style-check the tests, though, so I won't object if you want to move forward here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.