When drush is in a vendor dir, try to automatically find root. #3101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Preflight/Preflight.php
Outdated
| // Try two approaches. | ||
| if (!$selectedRoot = $this->preflightArgs->selectedSite(DRUSH_COMMAND)) { | ||
| $selectedRoot = $this->preflightArgs->selectedSite($this->environment->cwd()); | ||
| } | ||
| return $this->setSelectedSite($selectedRoot, $this->environment->vendorPath()); |
There was a problem hiding this comment.
$this->environment->vendorPath() is used later to fall back to finding the Drupal site from the vendor directory. If this isn't working correctly in the SUT (e.g. due to symlinking), then perhaps change this expression to something else. For example, maybe:
$selectedRoot = $this->preflightArgs->selectedSite($this->environment->cwd());
$fallbackPath = $this->preflightArgs->selectedSite(DRUSH_COMMAND);
return $this->setSelectedSite($selectedRoot, $fallbackPath)
I haven't tried this, but that's how setSelectedSite() is supposed to work, anyway. "Selected root" is the root the user selected via cwd et. al., and the fallback path is information used to find the site from other information e.g. vendor path.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.