Fix infinite recursion when empty path is provided to drush_mkdir #2862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems like we should fix the caller. |
|
This causes segfaults depending on php settings and it took me a while to get here. I'll report the upstream error that leads to it when I find it. Input validation is the responsibility of the function itself though. PHP's built in mkdir doesn't break like this. |
|
+1 on merging this. |
|
OK. The PR currently handles empty string. Should it handle NULL? |
|
Yeah, |
|
empty will return true for the string '0' which is a valid folder name. I added a type check for $path and made a new pull request #2864 since I can't seem to re-open this one or make changes to it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Encountered this while trying debug an issue with site install.