Allow Symfony 3 components for site-local installs of Drush 8.x #2800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Drush 8.x will not support site-local installation for Drupal 8.4.x or later. Use Drush 9 for that. |
|
Let's revisit this for 8.1.15 |
…e keeping global installs at Symfony 2.
greg-1-anderson
force-pushed
the
allow-symfony-3
branch
from
22b749a to
e7cb687
Compare
|
Here are the installation permutations with this PR:
The composer.lock file has Symfony 2. |
Much needed! |
|
Added a followup for this in core: https://www.drupal.org/node/2916204 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While keeping global installs at Symfony 2.
If we do not allow Symfony 3 components, then site-local installs of Drush 8.x will not work with Drupal 8.4.x. However, if we simply add Symfony 3 to the require section, then we will break global installs of Drush for Drupal 8.3.x. To prevent this, we pin Symfony components to Symfony 2 in require-dev.
c.f. #2799