Remove Finder+Launcher. Use DrupalFinder #2749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -239,7 +239,6 @@ function drush_get_global_options($brief = FALSE) { | |||
| $options['alias-path'] = array('context' => 'ALIAS_PATH', 'local-context-only' => TRUE, 'merge-pathlist' => TRUE, 'propagate-cli-value' => TRUE, 'description' => "Specifies the list of paths where drush will search for alias files.", 'example-value' => '/path/alias1:/path/alias2'); | |||
| $options['confirm-rollback'] = array('description' => 'Wait for confirmation before doing a rollback when something goes wrong.'); | |||
| $options['complete-debug'] = array('hidden' => TRUE, 'description' => "Turn on debug mode forf completion code"); | |||
| $options['php-options'] = array('description' => "Options to pass to `php` when running drush. Only effective when using the drush.launcher script.", 'never-propagate' => TRUE, 'example-value' => '-d error_reporting="E_ALL"'); | |||
There was a problem hiding this comment.
What happened to php-options? Don't we still need this in backend invoke?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the finder and launcher. The recommended way to run Drush is to call vendor/bin/drush from the root of your project or anywhere inside the docroot. This new flexibility comes from the DrupalFinder, which is now called from within drush_locate_root().
This PR also adds a
sutscript at the root of our project. That lets you run drush commands on your SUT for drush development purposes.There may be more to clean up in backend and sitealiases related to this PR. Input welcome.
The drush-shim is our early attempt at a global launcher. Lets discuss that at https://github.com/webflo/drush-shim/issues