-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Annotated command implementation of 'core-status' command. #2437
Conversation
Fixed one bug in the upstream, but one more remains. All of the possible fields are displayed, even if some fields contain no data. Fields with no data should be omitted from the output. |
@greg-1-anderson - Does your recent output-formatters work fix #130 for annotated commands? |
b0e75b7
to
bd0436c
Compare
@weitzman Yes, with the addition of the --include-field-labels option to the status command. This could be a global option, perhaps. Having a hard time figuring out why the tests are failing. Sometimes the site-under-test ends up at |
Okay, got the tests using only "standard" forms, no shortcuts, when using Not implemented yet:
|
I think we can drop support for the argument and drop support for --pipe
option. Folks can be explicit.
|
@greg-1-anderson - I'm OK if we merge this without all that checklist complete. |
…move field labels in the status command.
a26f85f
to
c9da006
Compare
Latest commit should take care of the primary backwards-compatibility issues. Let's see how the tests fare. |
The handling of default fields is not working right. If --fields is not specified, an error is returned. If a valid list of --fields is given, they will be printed.