Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore phpstorm file in git #2210

Closed
wants to merge 1 commit into from

Conversation

gggeek
Copy link

@gggeek gggeek commented Jun 8, 2016

No description provided.

@damiankloip
Copy link
Contributor

Wouldn't this just be in your global or user level gitignore?

@gggeek
Copy link
Author

gggeek commented Jun 10, 2016

Of course it could, but I think that the cost/benefit ratio justifies it: one line in the gitignore is not a great maintenance burden, and having it there makes the project a tad more friendly for new devs joining.

As a side note: I do not have my per-user .gitignore set up properly because I use a vast amount of vms/containers, and sometimes run the git command, for the same project, from within 3 different envs (windows, linux vm, container). I understand this might setup be uncommon, so I leave it up to you to decide...

@weitzman
Copy link
Member

OK, but I'm curious why are you making commits inside of the Drush directory? Users are supposed to add config/command/alias files elsewhere?

@gggeek
Copy link
Author

gggeek commented Jul 12, 2016

@weitzman sorry, what I did in order to send PRs to Drush was to: check out Drush in a dedicated folder without even having Drupal installed there, edit files, commit, send PR. Maybe it is not the standard workflow for Drush developers, but it worked for me...

weitzman added a commit that referenced this pull request Aug 6, 2016
@weitzman weitzman closed this in 57a3c8a Aug 6, 2016
@weitzman
Copy link
Member

weitzman commented Aug 6, 2016

added. had a typo so i did it manually.

thanks.

mikeker pushed a commit to mikeker/drush that referenced this pull request Aug 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants