Adds sub-options for xhprof_enable() flags. #2174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (!defined('XHPROF_FLAGS_NO_BUILTINS')) { | ||
| define('XHPROF_FLAGS_NO_BUILTINS', 1); | ||
| define('XHPROF_FLAGS_CPU', 2); | ||
| define('XHPROF_FLAGS_MEMORY', 3); |
There was a problem hiding this comment.
Added these defines because xhprof is not installed by default on Travis CI. Additionally xhprof extension is not available on PHP 7 yet.
weitzman
pushed a commit
that referenced
this pull request
Jul 18, 2016
|
This looks great. Sorry it took ages to review. Thanks for the test case as well. |
mikeker
pushed a commit
to mikeker/drush
that referenced
this pull request
Aug 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function
xhprof_enable()takes flags to control the profiling of CPU, memory, and PHP built-ins. This change would add a drush sub-option for each of the flags.Related to how sub-options appear to work currently, see #2173.