Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set correct Drupal root when a relative path is provided #2318

Closed
weitzman opened this issue Aug 19, 2016 · 1 comment
Closed

Set correct Drupal root when a relative path is provided #2318

weitzman opened this issue Aug 19, 2016 · 1 comment
Labels
area-windows type-bug

Comments

@weitzman
Copy link
Member

The Finder does a chdir when --root is provided. This complicates later processing of --root in drush_preflight_root() when a relative path is provided (e.g. -r web). That relative path is not transformed into an absolute path by the shell, at least not on Windows.
@weitzman
Copy link
Member Author

Perhaps we need to unset the -r/--root option if we handle it in the Finder?

weitzman added a commit that referenced this issue Aug 25, 2016
@weitzman
Fix #2318. Set cwd when Finder is launching via proc_open().
4dad498
weitzman added a commit that referenced this issue Aug 26, 2016
@weitzman
Fix #2318. Set cwd when Finder is launching via proc_open().
da5ee72
mikeker pushed a commit to mikeker/drush that referenced this issue Aug 10, 2017
@weitzman @mikeker
Fix drush-ops#2318. Set cwd when Finder is launching via proc_open().
becd27d
@weitzman weitzman mentioned this issue May 7, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-windows type-bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@weitzman