Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make drush_drupal_version() pull from Boot classes #1724

Closed
quicksketch opened this issue Oct 30, 2015 · 2 comments
Closed

Make drush_drupal_version() pull from Boot classes #1724

quicksketch opened this issue Oct 30, 2015 · 2 comments

Comments

@quicksketch
Copy link
Contributor

With #342 and other enchancements, we have Boot classes that separate out the version-specific logic when bootstrapping D6/D7/D8 (and Backdrop).

One area where we're having trouble in Backdrop land is that drush_drupal_version() is hard-coded to look in particular areas for the VERSION constant. As Backdrop wants to identify itself as D7 (for now), but the logic is hard-coded, we are unable to make drush recocognize Backdrop without some pretty sad hacking (like making an empty file at includes/bootstrap.inc that contains a VERSION constant).

Separating out the logic for different versions of Drupal is what Boot classes were intended for, so could we move the logic of drush_drupal_version() into these classes?

@quicksketch
Copy link
Contributor Author

Hopefully this isn't too presumptious, but here are PRs for 7.x and master:

7.x: #1725
master: #1726

If they need work I can just turn into a single PR if that's preferred.

quicksketch added a commit to quicksketch/drush that referenced this issue Oct 30, 2015
quicksketch added a commit to quicksketch/drush that referenced this issue Oct 30, 2015
quicksketch added a commit to quicksketch/drush that referenced this issue Oct 30, 2015
quicksketch added a commit to quicksketch/drush that referenced this issue Oct 30, 2015
weitzman added a commit that referenced this issue Nov 4, 2015
Issue #1724: Move logic for version information into Boot classes.
@quicksketch
Copy link
Contributor Author

Thanks @weitzman and @greg-1-anderson!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant