scan query: use columns instead of dimensions #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scan queries use the columns parameter (string array) to define the dimension to return [1]. Currently, pydruid is incorrectly filling a dimensions parameter, which ends up being ignored (and the scan query always return all dimensions). [1] http://druid.io/docs/latest/querying/scan-query.html Signed-off-by: Alejandro del Castillo <[email protected]>
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scan queries use the columns parameter (string array) to define the
dimension to return [1]. Currently, pydruid is incorrectly filling a
dimensions parameter, which ends up being ignored (and the scan query
always return all dimensions).
[1] http://druid.io/docs/latest/querying/scan-query.html
Signed-off-by: Alejandro del Castillo [email protected]