-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow figsize pass to audio_spectrogram_image #35
Conversation
Oooo, thanks for the fix, Lyra! But the checks failed because we need the change to go in the .ipynb file, not the .py file (as those are always overwritten by |
Clarified Contributing section, as per #35
just to clarify- I do have to run |
Yea you can't just edit on the web, the CI will fail due to timestamp errors, and the docs won't build correctly either. As per Contributing:
You need to run |
It might be easier if I just make the change and push it ,since I'm used to this stuff. (I could do it, and add a note in the Comment that I'm pasting in your change.) But I'd still be happy to wait for you to do it if you want to. |
works for me! I can try out the build tools later if I run into something again |
Ok, working on it! |
Closing this PR, as now implemented via Commit 448a754! 🥳 |
spectrogram_image
allows passing an optional figsize, but that arg is not propagated to theaudio_spectrogram_image
wrapper. This edit lets you control that directly, for example if you want wider spectrograms:wandb.Image(audio_spectrogram_image(fakes, figsize=(15, 4)))