pulled new Thrift definition from Apache Hive repo

[The-Alchemist]

Pulled Thrift def from https://raw.githubusercontent.com/apache/hive/master/service-rpc/if/TCLIService.thrift

This version includes TIMESTAMPLOCALTZ_TYPE, which was causing problems for me. See apache/superset#7520

[The-Alchemist]

Fixes #285

[CLAassistant]

All committers have signed the CLA.

[jphalip]

Thank you for working on this patch. What is the current status? What would it take to merge it? Thanks!

[The-Alchemist]

Thank you for working on this patch. What is the current status? What would it take to merge it? Thanks!

I haven't looked at this issue for a few years now. :)

Looks like just a small merge conflict in a unit test.

[jphalip]

Right, yeah it's been a few years now :)

I too ran into the issue with TIMESTAMPLOCALTZ. By chance are you in a position to update the PR, or would you need some help? If the latter, let me know if you have any tips on how I can pick it up. Thanks!

[The-Alchemist]

I too ran into the issue with TIMESTAMPLOCALTZ. By chance are you in a position to update the PR, or would you need some help? If the latter, let me know if you have any tips on how I can pick it up. Thanks!

@jphalip : I rebased it and fixed all the issues, I believe. Note, though, I did not regenerate from the latest Thrift definition, but it appears there's no significant changes.

[jphalip]

@The-Alchemist Thanks a lot! I appreciate it. I can look into updating to the latest definition.

Is it just a matter of running the following?

python generate.py https://raw.githubusercontent.com/apache/hive/master/service-rpc/if/TCLIService.thrift

[The-Alchemist]

@The-Alchemist Thanks a lot! I appreciate it. I can look into updating to the latest definition.

Is it just a matter of running the following?

python generate.py https://raw.githubusercontent.com/apache/hive/master/service-rpc/if/TCLIService.thrift

I think so, but it's been a while. Good luck =)

[jphalip]

I've just submitted an alternative PR here: #473