Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into issues with
drone-cli
being able to communicate to our drone instance that is fronted by an internally signed certificate.golang does have PRIVATE methods for getting the system root CAs. (
root*.go
files @ https://github.com/golang/go/tree/master/src/crypto/x509). This PR borrows that code and makes it public. I've only grabbed the code for OS X but other platforms could be adopted following the established pattern.The best solution would be to make
x509.systemRootsPool
public in golang and use it directly. This seems to have been requested @ golang/go#13335I tested this locally by updating
drone-cli
to use my fork ofdrone-go
it worked.