-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add retries
option
#43
Conversation
It can be enabled this way: ``` clone: retries: 3 ```
e77bae3
to
f2de155
Compare
28338a9
to
fd44ec6
Compare
Hi @julienduchesne this seems sensible, how where you going to pass the env var in from the runners ? |
I'd like to add a Currently, we are using this as a custom clone step |
Will be used to support drone/drone-git#43
Used to support drone/drone-git#43 Will require a go mod update to add the arg to the manifest: drone/runner-go#22
Thanks for the merge @tphoney. I also created these two PRs to expose the option: |
* Add retries option to the clone step Used to support drone/drone-git#43 Will require a go mod update to add the arg to the manifest: drone/runner-go#22 * Update `runner-go` to v1.12.0 * Add test
Tested on our pipelines Implemented in drone/drone-git#43 + drone-runners/drone-runner-docker#44 + drone/runner-go#22
@julienduchesne what's the delay between retries? should sleep for 5 or 10 seconds right? Otherwise, all retries happen very quickly. |
It uses the
PLUGIN_VAR
format in order to allow enabling it this way:Updated from #27