Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support host_aliases #47

Merged
merged 2 commits into from
Feb 16, 2022
Merged

feat: support host_aliases #47

merged 2 commits into from
Feb 16, 2022

Conversation

ysicing
Copy link
Contributor

@ysicing ysicing commented Jan 9, 2021

Signed-off-by: ysicing [email protected]

support pipeline hosts

host_aliases:
  - ip: 1.1.1.1.1
    hostnames: 
      - www.baidu.com

@CLAassistant
Copy link

CLAassistant commented Jan 9, 2021

CLA assistant check
All committers have signed the CLA.

@tphoney
Copy link

tphoney commented Jul 13, 2021

is #52 comparable to this ?

@ysicing ysicing closed this Aug 23, 2021
@ysicing ysicing reopened this Dec 24, 2021
@ysicing ysicing closed this Dec 24, 2021
@ysicing ysicing reopened this Dec 24, 2021
@ysicing
Copy link
Contributor Author

ysicing commented Dec 24, 2021

@tphoney No, this supports the definition of HostAliases in pipeline

merge origin code

Signed-off-by: ysicing <[email protected]>
@tphoney
Copy link

tphoney commented Feb 16, 2022

Hey @ysicing reviewing this again. The code looks good and we can merge it.
But can you give an example of how you would use the new variable, then i can add docs for it here https://docs.drone.io/runner/docker/configuration/reference/
or if you want to create the documentation for the feature, i can merge it.

@ysicing
Copy link
Contributor Author

ysicing commented Feb 16, 2022

@tphoney Hey, the document has been updated. docs#537

@tphoney
Copy link

tphoney commented Feb 16, 2022

Docs merged and PR merged.
Great work @ysicing i owe you a 🍺

@tphoney tphoney merged commit eacc3d2 into drone-runners:master Feb 16, 2022
@ysicing ysicing deleted the feat-hosts branch February 16, 2022 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants