-
Notifications
You must be signed in to change notification settings - Fork 25
bump logrus, go 1.17, enable M1 mac support #7
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @iameli you bumped the go version in the build file, but not in the go.mod. Otherwise this pr looks Brilliant 👍
@tphoney Got it, will do. When I upgrade that to Go 1.17, it prompts me that
When I run that, the build works but it removes all of the unused versions of github.com/drone/runner-go, among other things. I don't 100% understand go.sum; is it best practice to have them archived there or is it okay to remove them? |
Went ahead and ran |
thanks @iameli great work. MERGED 👍 |
Is a new build planned soon to provide the m1 prebuild binary? |
@FabianTerhorst If you need one I uploaded a prerelease build here, but would love an official one too! https://github.com/livepeer/drone-runner-exec/releases/tag/v1.0.0-beta.9-8-g1ada187 |
Thanks alot. |
@FabianTerhorst @iameli https://github.com/drone-runners/drone-runner-exec/releases/tag/v1.0.0-beta.10 released ! thanks for your patience |
Bumped logrus to v1.8.1. They're very committed to no breaking changes so this shouldn't change much.
Importantly, this includes a transitive dependency bump of
golang.org/x/sys
tov0.0.0-20220520151302-bc2c85ada10a
, which is a version that supports M1 arm64 macs. We've tested and it appears to work very well, enabling Drone to run builds on M1 Macs!EDIT: Also bumps the CI golang to 1.17; Go 1.12 didn't support M1 macs.