Skip to content
This repository has been archived by the owner on Oct 6, 2022. It is now read-only.

bump logrus, go 1.17, enable M1 mac support #7

Merged
merged 3 commits into from
Jun 22, 2022

Conversation

iameli
Copy link
Contributor

@iameli iameli commented Jun 6, 2022

Bumped logrus to v1.8.1. They're very committed to no breaking changes so this shouldn't change much.

Importantly, this includes a transitive dependency bump of golang.org/x/sys to v0.0.0-20220520151302-bc2c85ada10a, which is a version that supports M1 arm64 macs. We've tested and it appears to work very well, enabling Drone to run builds on M1 Macs!

EDIT: Also bumps the CI golang to 1.17; Go 1.12 didn't support M1 macs.

@CLAassistant
Copy link

CLAassistant commented Jun 6, 2022

CLA assistant check
All committers have signed the CLA.

@iameli iameli changed the title bump logrus, enable M1 mac support bump logrus, go 1.17, enable M1 mac support Jun 6, 2022
Copy link

@tphoney tphoney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @iameli you bumped the go version in the build file, but not in the go.mod. Otherwise this pr looks Brilliant 👍

@iameli
Copy link
Contributor Author

iameli commented Jun 14, 2022

@tphoney Got it, will do. When I upgrade that to Go 1.17, it prompts me that go mod tidy is necessary:

▶ scripts/build.sh
+ go build -o release/native/drone-runner-exec
go: updates to go.mod needed; to update it:
	go mod tidy

When I run that, the build works but it removes all of the unused versions of github.com/drone/runner-go, among other things. I don't 100% understand go.sum; is it best practice to have them archived there or is it okay to remove them?

@iameli
Copy link
Contributor Author

iameli commented Jun 14, 2022

Went ahead and ran go mod tidy and it resulted in c3104ba - should work well if that's what we're going for!

@tphoney
Copy link

tphoney commented Jun 22, 2022

thanks @iameli great work. MERGED 👍

@tphoney tphoney merged commit 9decf29 into drone-runners:master Jun 22, 2022
@tphoney tphoney added the enhancement New feature or request label Jun 22, 2022
@FabianTerhorst
Copy link

Is a new build planned soon to provide the m1 prebuild binary?

@iameli
Copy link
Contributor Author

iameli commented Jun 22, 2022

@FabianTerhorst If you need one I uploaded a prerelease build here, but would love an official one too! https://github.com/livepeer/drone-runner-exec/releases/tag/v1.0.0-beta.9-8-g1ada187

@FabianTerhorst
Copy link

Thanks alot.

@tphoney
Copy link

tphoney commented Jun 23, 2022

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants