This PR adds a new environment variable DRONE_RUNNER_NETWORK_IPAM_SUBNET to the drone-runner-docker project. This variable allows users to specify a custom subnet for the Docker network created by the runner.
#64
+51
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Hi, could someone give this a look, we also run into similar issue that adding more subnet would be very convenient. Maybe @eoinmcafee00 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new environment variable
DRONE_RUNNER_NETWORK_IPAM_SUBNETto thedrone-runner-dockerproject. This variable allows users to specify a custom subnet for the Docker network created by the runner.This is useful in situations where the default subnets used by Docker conflict with the host's network configuration, causing errors such as "Error response from daemon: could not find an available, non-overlapping IPv4 address pool among the defaults to assign to the network".
To use this option, users can set the
DRONE_RUNNER_NETWORK_IPAM_SUBNETenvironment variable to a valid CIDR-formatted subnet, such as "192.168.1.0/24". The runner will then use this subnet when creating the Docker network.