Add dynamic wait for vm hibernate #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eoinmcafee00
reviewed
May 4, 2022
| "github.com/drone-runners/drone-runner-aws/internal/certs" | ||
| "github.com/drone-runners/drone-runner-aws/store" | ||
| "github.com/drone-runners/drone-runner-aws/types" | ||
| "github.com/drone/runner-go/logger" | ||
| lehttp "github.com/harness/lite-engine/cli/client" |
There was a problem hiding this comment.
I guess ordering is correct. No changes are shown on go fmt
eoinmcafee00
reviewed
May 4, 2022
| "fmt" | ||
| "runtime/debug" | ||
| "sort" | ||
| "sync" | ||
| "time" | ||
|
|
||
| "github.com/cenkalti/backoff/v4" |
There was a problem hiding this comment.
this should be below drone imports in a separate section. See how other files do it in the repo
There was a problem hiding this comment.
because it's 3rd party
There was a problem hiding this comment.
ignore you've already done it
eoinmcafee00
approved these changes
May 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.