feat: [CDE-365]: Send the whole gitspace agent script instead of individual params #510
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since we wanted to send more params for container name, tag, image etc, instead of adding so many params, thought of sending the whole script and appending to the existing one in cloudinit.go
To keep it backward compatible, I haven't removed any existing params.
This would be the script coming from CDE Manager with all the replaced values.
Commit Checklist
Thank you for creating a pull request! To help us review / merge this can you make sure that your PR adheres as much as possible to the following.
The Basics
If you are adding new functionality, please provide evidence of the new functionality.