start publishing tags based on supported os/arch #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vistaarjuneja
force-pushed
the
add-tags-support
branch
from
e84aee5 to
cc5834d
Compare
shubham149
reviewed
Aug 12, 2022
| func parseTags(pf *config.PoolFile) []string { | ||
| tags := []string{} | ||
| for i := range pf.Instances { | ||
| t := pf.Instances[i].Platform.OS + "-" + pf.Instances[i].Platform.Arch |
There was a problem hiding this comment.
os is used as darwin instead of macos
There was a problem hiding this comment.
let's keep it for now. We can check with brad whether darwin is a better alternative than mac and update accordingly
There was a problem hiding this comment.
we can review it when mac os support is added back
shubham149
approved these changes
Aug 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Checklist
Thank you for creating a pull request! To help us review / merge this can you make sure that your PR adheres as much as possible to the following.
The Basics
If you are adding new functionality, please provide evidence of the new functionality.