Add task implementations for by-passing the java delegate #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shubham149
reviewed
Jul 13, 2022
| func (c *dliteCommand) startPoller(ctx context.Context, tags []string) error { | ||
| r := router.NewRouter(routeMap(c)) | ||
| // TODO (Vistaar): Set a token updater thread which resets the token | ||
| token, err := delegate.Token("audience", "issuer", c.env.Dlite.AccountID, c.env.Dlite.AccountSecret, tokenExpiry) |
There was a problem hiding this comment.
What happens when token expires now?
There was a problem hiding this comment.
Have set it to 10 hours for now - after that dlite will not be able to talk to manager. There is an open ticket to fix that: https://harness.atlassian.net/browse/CI-4946. I will see how java delegate does it, if they set infinite expiry will do the same.
| StringVar(&c.poolFile) | ||
| } | ||
|
|
||
| func (c *dliteCommand) startPoller(ctx context.Context, tags []string) error { |
There was a problem hiding this comment.
We should also delete the pools in case we receive sigterm call if reuse pool is not set. Can be taken up in next PR.
There was a problem hiding this comment.
ack. Will create a ticket for it
shubham149
reviewed
Jul 13, 2022
shubham149
approved these changes
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support to directly start accepting and executing Harness tasks.
It uses wings-software/dlite as a library to poll for tasks and only contains implementations of the initialize, execute and destroy tasks.
It contains the mapping of the task types to the handlers which receive the task as input and should write the response back after execution.