Allow insecure and/or anonymous registry #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
techknowlogick
approved these changes
Nov 25, 2019
lafriks
approved these changes
Nov 25, 2019
tboerger
reviewed
Nov 25, 2019
plugin.go
Outdated
| @@ -73,18 +74,22 @@ func mainfestToolPath() string { | |||
| func (p *Plugin) Exec() error { | |||
| args := []string{} | |||
|
|
|||
| if p.Config.Username == "" { | |||
| if p.Config.Username == "" && !p.Config.Insecure { | |||
There was a problem hiding this comment.
Why tied to the username? First of all insecure doesn't check certificates or is working without certificates, that doesn't imply anonymous authentication.
There was a problem hiding this comment.
I was wrong. I have separated anonymous access from insecure access.
c0va23
changed the title
|
@tboerger, I've separated insecure access from anonymous access. And tested it together on full pipeline. Separately, I checked that the plugin will return errors if you do not specify a password or username. Checked only under linux, to windows I have no access. |
tboerger
approved these changes
Nov 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I have implemented support for insecure registries. Similar to "plugins/docker".
I also added the possibility of anonymous access to the registry.
I also updated manifest-tool to version 1.0.0, because starting from this version there is support for insecure registries.