Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

重构告警规则 #442

Open
yanhom1314 opened this issue Jul 18, 2024 · 2 comments
Open

重构告警规则 #442

yanhom1314 opened this issue Jul 18, 2024 · 2 comments
Assignees
@TheFatRatre
Labels
feature refactor

Comments

@yanhom1314
Copy link
Collaborator

yanhom1314 commented Jul 18, 2024 •
edited
Loading

首先感谢您使用 DynamicTp，如果对项目有好的想法建议，请按照下述模板提议讨论，建议使用 Markdown 语法。

方案描述

目前dynamictp的告警项配置比较简单，设计也不是很合理，参考skywalking告警规则重构告警配置模块

https://skywalking.apache.org/docs/main/latest/en/setup/backend/backend-alarm/

应用场景

使告警可配置度高，更精准

难度风险

低

外部依赖

无
@TheFatRatre
Copy link
Contributor

可以把这个分配给我吗

@yanhom1314
Copy link
Collaborator Author

可以把这个分配给我吗

指给你了

TheFatRatre added a commit to TheFatRatre/dynamic-tp that referenced this issue Aug 3, 2024
@TheFatRatre
重构报警规则，增加count，op字段 dromara#442
40e8ae4
TheFatRatre added a commit to TheFatRatre/dynamic-tp that referenced this issue Aug 8, 2024
@TheFatRatre
undo dromara#442
c7ea8cb
TheFatRatre added a commit to TheFatRatre/dynamic-tp that referenced this issue Aug 10, 2024
@TheFatRatre
添加period字段，构造加入period后的alarm逻辑;TpExecutorProps移除runTimeout，queueTimeo…
8ac8e84 
…ut字段，以threshold替代 dromara#442
TheFatRatre added a commit to TheFatRatre/dynamic-tp that referenced this issue Aug 16, 2024
@TheFatRatre
规范格式 dromara#442
8ad9469
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TheFatRatre TheFatRatre

Labels
feature refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yanhom1314 @TheFatRatre