-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Light mode & dark mode theming #92
Conversation
[WIP]
- Light Mode & Dark Mode ThemingThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do proceed with this approach. Superb!
Needing to kickstart work on #89. So proceeding to merge this in, then you can branch out and continue the work and every page can be it's own. You can work on the speaker details page and the session details page for dark mode. I should hopefully be done with the data-loading issue before the night ends and have it merged in so that the dark mode work isn't badly behind. I should be available for a bit longer tonight in case anything isn't as clear or you have any doubts. Again a need for constant comms at this stage to prevent unpleasant merge conflicts. |
Got it @MillerAdulu, I'll pull the new changes from |
Description
This PR:
Light Theme
Dark Theme
Type of Change
Test Changes on Device
You can download your APK from Firebase App Distribution once this PR builds successfully via the following link: https://appdistribution.firebase.dev/i/c796669942f8a811