Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Light mode & dark mode theming #92

Merged
merged 7 commits into from
Aug 18, 2024
Merged

Conversation

root458
Copy link
Contributor

@root458 root458 commented Aug 17, 2024

Description

This PR:

  • Sets up light mode and dark mode theming, initiates Light theme & dark theme #90
  • The change starts with the About page. Sample previews are shown below.

Light Theme

Dark Theme

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

Test Changes on Device

You can download your APK from Firebase App Distribution once this PR builds successfully via the following link: https://appdistribution.firebase.dev/i/c796669942f8a811

@MillerAdulu MillerAdulu marked this pull request as draft August 17, 2024 18:09
@MillerAdulu MillerAdulu changed the title [WIP] - Light Mode & Dark Mode Theming Light mode & dark mode theming Aug 17, 2024
@MillerAdulu MillerAdulu self-requested a review August 17, 2024 18:10
Copy link
Contributor

@MillerAdulu MillerAdulu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do proceed with this approach. Superb!

lib/common/widgets/app_bar/app_bar.dart Show resolved Hide resolved
lib/common/utils/misc.dart Show resolved Hide resolved
@MillerAdulu
Copy link
Contributor

@root458,

Needing to kickstart work on #89. So proceeding to merge this in, then you can branch out and continue the work and every page can be it's own.

You can work on the speaker details page and the session details page for dark mode. I should hopefully be done with the data-loading issue before the night ends and have it merged in so that the dark mode work isn't badly behind. I should be available for a bit longer tonight in case anything isn't as clear or you have any doubts. Again a need for constant comms at this stage to prevent unpleasant merge conflicts.

@MillerAdulu MillerAdulu marked this pull request as ready for review August 18, 2024 14:26
@MillerAdulu MillerAdulu added this pull request to the merge queue Aug 18, 2024
Merged via the queue into droidconKE:main with commit 3d62857 Aug 18, 2024
1 check passed
@root458
Copy link
Contributor Author

root458 commented Aug 18, 2024

Got it @MillerAdulu,

I'll pull the new changes from main and continue.

@MillerAdulu MillerAdulu mentioned this pull request Sep 16, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants