Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load feed #54

Closed
wants to merge 2 commits into from
Closed

Load feed #54

wants to merge 2 commits into from

Conversation

DevshiDeno
Copy link
Contributor

@DevshiDeno DevshiDeno commented Aug 8, 2024

Description

load feed issue

I created the necessary models required to handle event feeds gotten from the API and used Cubit to track state on the feed UI screen.

Closes #48

Type of Change

enhancement

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

Test Changes on Device

You can download your APK from Firebase App Distribution once this PR builds successfully via the following link: https://appdistribution.firebase.dev/i/c796669942f8a811

@MillerAdulu MillerAdulu self-requested a review August 8, 2024 18:51
@MillerAdulu
Copy link
Contributor

@DevshiDeno

Kindly add a video description to showcase the interaction of the UI concerning this feature.

@DevshiDeno
Copy link
Contributor Author

DevshiDeno commented Aug 8, 2024 via email

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please delete this entire file. It's not needed.

Future<void> fetchFeeds() async {
emit(const FetchFeedState.loading());
try {
final feeds = await _apiRepository.fetchFeeds(event: '');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The slug for the feed of this event as per the documentation at this URL should be droidconke-2022-281

https://documenter.getpostman.com/view/3385291/SzS4TTXb#a443ec01-1cf8-41d9-bfd5-56fb6c228de4

Please make this slight addition.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete this file.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete this file.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete this file.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete this file.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete this file.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete this file.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete this file.

@MillerAdulu
Copy link
Contributor

@DevshiDeno,

Once you are done with the changes, check the failing pipeline here: https://github.com/droidconKE/flutterconKEApp/actions/runs/10305939605/job/28533957201?pr=54

Fix the formatting issue by running the fmt command in the Makefile

@MillerAdulu
Copy link
Contributor

The code generally looks OK. Looking forward to the corrections and this can be merged in quickly.

@MillerAdulu
Copy link
Contributor

@DevshiDeno,

Trusting that you are still on this.

@DevshiDeno
Copy link
Contributor Author

DevshiDeno commented Aug 11, 2024 via email

@MillerAdulu MillerAdulu mentioned this pull request Aug 14, 2024
@MillerAdulu
Copy link
Contributor

Made changes on #59 that's now merged. Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Load feed
2 participants