Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Authentication #42

Merged
merged 19 commits into from
Jul 31, 2024
Merged

Authentication #42

merged 19 commits into from
Jul 31, 2024

Conversation

MillerAdulu
Copy link
Contributor

@MillerAdulu MillerAdulu commented Jul 30, 2024 •
edited
Loading

Description

This PR:

  • Removes shared_preferences in favour of hive
  • Configures authentication on the app with Google & Firebase: Closes Authentication  #34
  • Reworks the navigation system to go_router: Closes Update routing approach #22
  • Adds a public-facing keystore to ensure dev on Android can continue without having to add everyone's SHA1 key to the Firebase project which is a requirement for auth with Google needed to get tokens that can be used to access the API

Instead of using a BLoC for the authentication, opted for a cubit instead as I view it to be unnecessary complexity as per the official docs here

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

Test Changes on Device

You can download your APK from Firebase App Distribution once this PR builds successfully via the following link: https://appdistribution.firebase.dev/i/c796669942f8a811

@MillerAdulu MillerAdulu added the enhancement New feature or request label Jul 30, 2024
@MillerAdulu MillerAdulu marked this pull request as draft July 30, 2024 23:18
mboyamike
mboyamike suggested changes Jul 31, 2024
View reviewed changes
Copy link
Contributor

@mboyamike mboyamike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also seen you did some work on setting up iOS

I don't envy you for working with cocoapods 😂😂

Thanks for this. Really great work

lib/common/repository/auth_repository.dart Show resolved Hide resolved
lib/features/splash/splash_screen.dart Outdated Show resolved Hide resolved
@mboyamike
Copy link
Contributor

The approach looks good to me!
Maybe once the backend has been fixed we'll try it out

@MillerAdulu MillerAdulu marked this pull request as ready for review July 31, 2024 22:25
@MillerAdulu MillerAdulu merged commit a67f14c into main Jul 31, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mboyamike mboyamike mboyamike approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Authentication Update routing approach
2 participants
@MillerAdulu @mboyamike